yggdrasil/binutils-gdb
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[PR20402][LD][AARCH64]Don't emit RELATIVE relocation for absolute symbols which are resolved at static linking time.

Browse Source 
For absolute symbols which are forced local or not dynamic, the ABS relocation
should be resolved at static linking time.

Originally, an RELATIVE/ABS relocation will be generated even for absolution
symbols for the dynamic linker to resolve.

bfd/

2018-03-07  Renlin Li  <renlin.li@arm.com>

	PR ld/20402
	* elfnn-aarch64.c (elfNN_aarch64_final_link_relocate): Check absolute symbol,
	and don't emit relocation in specific case.

ld/

2018-03-07  Renlin Li  <renlin.li@arm.com>

	PR ld/20402
	* testsuite/ld-aarch64/aarch64-elf.exp: Run new test.
	* testsuite/ld-aarch64/pr20402.s: New.
	* testsuite/ld-aarch64/pr20402.d: New.
This commit is contained in:
Renlin Li 2018-03-07 09:27:45 +00:00
parent e95a97d41a
commit 0c1ded8dc0
6 changed files with 38 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
bfd/ChangeLog
View File

@ -1,3 +1,9 @@
2018-03-07 Renlin Li <renlin.li@arm.com>
PR ld/20402
* elfnn-aarch64.c (elfNN_aarch64_final_link_relocate): Check absolute
symbol, and don't emit relocation in specific case.
2018-03-07 Alan Modra <amodra@gmail.com>
* elf64-mips.c (mips_elf64_rtype_to_howto): Return NULL on error.

13
bfd/elfnn-aarch64.c
View File

@ -5074,6 +5074,7 @@ elfNN_aarch64_final_link_relocate (reloc_howto_type *howto,
asection *base_got;
bfd_vma orig_value = value;
bfd_boolean resolved_to_zero;
bfd_boolean abs_symbol_p;
globals = elf_aarch64_hash_table (info);
@ -5093,6 +5094,9 @@ elfNN_aarch64_final_link_relocate (reloc_howto_type *howto,
weak_undef_p = (h ? h->root.type == bfd_link_hash_undefweak
: bfd_is_und_section (sym_sec));
abs_symbol_p = (h !=NULL && h->root.type == bfd_link_hash_defined
&& bfd_is_abs_section (h->root.u.def.section));
/* Since STT_GNU_IFUNC symbol must go through PLT, we handle
it here if it is defined in a non-shared object. */
@ -5360,6 +5364,12 @@ bad_ifunc_reloc:
skip = TRUE;
relocate = TRUE;
}
else if (abs_symbol_p)
{
/* Local absolute symbol. */
skip = (h->forced_local || (h->dynindx == -1));
relocate = skip;
}
outrel.r_offset += (input_section->output_section->vma
+ input_section->output_offset);
@ -5369,8 +5379,7 @@ bad_ifunc_reloc:
else if (h != NULL
&& h->dynindx != -1
&& (!bfd_link_pic (info)
|| !(bfd_link_pie (info)
|| SYMBOLIC_BIND (info, h))
|| !(bfd_link_pie (info) || SYMBOLIC_BIND (info, h))
|| !h->def_regular))
outrel.r_info = ELFNN_R_INFO (h->dynindx, r_type);
else

7
ld/ChangeLog
View File

@ -1,3 +1,10 @@
2018-03-07 Renlin Li <renlin.li@arm.com>
PR ld/20402
* testsuite/ld-aarch64/aarch64-elf.exp: Run new test.
* testsuite/ld-aarch64/pr20402.s: New.
* testsuite/ld-aarch64/pr20402.d: New.
2018-03-06 Jim Wilson <jimw@sifive.com>
PR 22920

1
ld/testsuite/ld-aarch64/aarch64-elf.exp
View File

@ -286,6 +286,7 @@ run_dump_test_lp64 "tprel_g2_overflow"
run_dump_test "tprel_add_lo12_overflow"
run_dump_test "protected-data"
run_dump_test_lp64 "pr22764"
run_dump_test_lp64 "pr20402"
# ifunc tests
run_dump_test "ifunc-1"

7
ld/testsuite/ld-aarch64/pr20402.d Normal file
View File

@ -0,0 +1,7 @@
#ld: -pie -defsym foo=0x1 -defsym bar=0x2
#readelf: -r
Relocation section '\.rela\.dyn' at offset .* contains 2 entries:
Offset Info Type Sym\. Value Sym\. Name \+ Addend
000000000000 000000000000 R_AARCH64_NONE 0
000000000000 000000000000 R_AARCH64_NONE 0

6
ld/testsuite/ld-aarch64/pr20402.s Normal file
View File

@ -0,0 +1,6 @@
.text
.global _start
.hidden foo
_start:
.xword foo
.xword bar