yggdrasil/binutils-gdb
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

gdb: rename target_read_auxv(target_ops *) to target_read_auxv_raw

Browse Source 
Having two overloads of target_read_auxv that don't have the same goals
is confusing.  Rename the one that reads from an explicit target_ops to
target_read_auxv_raw.  Also, it occured to me that the non-raw version
could use the raw version, that reduces duplication a bit.

Change-Id: I28e5f7cecbfcacd0174d4686efb3e4a23b4ad491
This commit is contained in:
Simon Marchi 2022-10-11 20:53:39 -04:00
parent 8652404e81
commit 1639fab33b
7 changed files with 8 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
gdb/aarch64-linux-tdep.c
View File

@ -780,7 +780,7 @@ aarch64_linux_core_read_description (struct gdbarch *gdbarch,
struct target_ops *target, bfd *abfd)
{
asection *tls = bfd_get_section_by_name (abfd, ".reg-aarch-tls");
gdb::optional<gdb::byte_vector> auxv = target_read_auxv (target);
gdb::optional<gdb::byte_vector> auxv = target_read_auxv_raw (target);
CORE_ADDR hwcap = linux_get_hwcap (auxv, target, gdbarch);
CORE_ADDR hwcap2 = linux_get_hwcap2 (auxv, target, gdbarch);

2
gdb/arm-fbsd-tdep.c
View File

@ -238,7 +238,7 @@ arm_fbsd_core_read_description (struct gdbarch *gdbarch,
{
asection *tls = bfd_get_section_by_name (abfd, ".reg-aarch-tls");
gdb::optional<gdb::byte_vector> auxv = target_read_auxv (target);
gdb::optional<gdb::byte_vector> auxv = target_read_auxv_raw (target);
return arm_fbsd_read_description_auxv (auxv, target, gdbarch, tls != nullptr);
}

2
gdb/arm-linux-tdep.c
View File

@ -732,7 +732,7 @@ arm_linux_core_read_description (struct gdbarch *gdbarch,
struct target_ops *target,
bfd *abfd)
{
gdb::optional<gdb::byte_vector> auxv = target_read_auxv (target);
gdb::optional<gdb::byte_vector> auxv = target_read_auxv_raw (target);
CORE_ADDR arm_hwcap = linux_get_hwcap (auxv, target, gdbarch);
if (arm_hwcap & HWCAP_VFP)

5
gdb/auxv.c
View File

@ -363,8 +363,7 @@ target_read_auxv ()
if (info == nullptr)
{
info = auxv_inferior_data.emplace (inf);
info->data = target_read_alloc (inf->top_target (), TARGET_OBJECT_AUXV,
nullptr);
info->data = target_read_auxv_raw (inf->top_target ());
}
return info->data;
@ -373,7 +372,7 @@ target_read_auxv ()
/* See auxv.h. */
gdb::optional<gdb::byte_vector>
target_read_auxv (target_ops *ops)
target_read_auxv_raw (target_ops *ops)
{
return target_read_alloc (ops, TARGET_OBJECT_AUXV, NULL);
}

2
gdb/auxv.h
View File

@ -52,7 +52,7 @@ extern gdb::optional<gdb::byte_vector> target_read_auxv ();
/* Read auxv data from OPS. */
extern gdb::optional<gdb::byte_vector> target_read_auxv (target_ops *ops);
extern gdb::optional<gdb::byte_vector> target_read_auxv_raw (target_ops *ops);
/* Search AUXV for an entry with a_type matching MATCH.

2
gdb/ppc-linux-tdep.c
View File

@ -1599,7 +1599,7 @@ ppc_linux_core_read_description (struct gdbarch *gdbarch,
if (vsx)
features.vsx = true;
gdb::optional<gdb::byte_vector> auxv = target_read_auxv (target);
gdb::optional<gdb::byte_vector> auxv = target_read_auxv_raw (target);
CORE_ADDR hwcap = linux_get_hwcap (auxv, target, gdbarch);
features.isa205 = ppc_linux_has_isa205 (hwcap);

2
gdb/s390-linux-tdep.c
View File

@ -332,7 +332,7 @@ s390_core_read_description (struct gdbarch *gdbarch,
struct target_ops *target, bfd *abfd)
{
asection *section = bfd_get_section_by_name (abfd, ".reg");
gdb::optional<gdb::byte_vector> auxv = target_read_auxv (target);
gdb::optional<gdb::byte_vector> auxv = target_read_auxv_raw (target);
CORE_ADDR hwcap = linux_get_hwcap (auxv, target, gdbarch);
bool high_gprs, v1, v2, te, vx, gs;