yggdrasil/binutils-gdb
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

objcopy --weaken-symbol: apply to STB_GNU_UNIQUE symbols

Browse Source 
PR binutils/28926
    * objcopy.c (filter_symbols): Apply weaken to STB_GNU_UNIQUE symbols
    * NEWS: Mention feature.
    * testsuite/binutils-all/objcopy.exp (objcopy_test_symbol_manipulation): New test.
    * testsuite/binutils-all/weaken-gnu-unique.s: New.
This commit is contained in:
Fangrui Song 2022-03-16 09:38:37 -07:00
parent b1b9c4115e
commit 260ecdcec4
5 changed files with 24 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
binutils/ChangeLog
View File

@ -1,3 +1,11 @@
2022-03-16 Fangrui Song <maskray@google.com>
PR binutils/28926
* objcopy.c (filter_symbols): Apply weaken to STB_GNU_UNIQUE symbols
* NEWS: Mention feature.
* testsuite/binutils-all/objcopy.exp (objcopy_test_symbol_manipulation): New test.
* testsuite/binutils-all/weaken-gnu-unique.s: New.
2022-03-16 Martin Storsjö <martin@martin.st>
PR 28885

2
binutils/NEWS
View File

@ -2,6 +2,8 @@
* Add an option to objdump and readelf to prevent attempts to access debuginfod
servers when following links.
* objcopy --weaken, --weaken-symbol, and --weaken-symbols now make ELF
STB_GNU_UNIQUE symbols weak.
Changes in 2.38:

4
binutils/objcopy.c
View File

@ -1681,11 +1681,11 @@ filter_symbols (bfd *abfd, bfd *obfd, asymbol **osyms,
if (keep)
{
if (((flags & BSF_GLOBAL) != 0
if (((flags & (BSF_GLOBAL | BSF_GNU_UNIQUE))
|| undefined)
&& (weaken || is_specified_symbol (name, weaken_specific_htab)))
{
sym->flags &= ~ BSF_GLOBAL;
sym->flags &= ~ (BSF_GLOBAL | BSF_GNU_UNIQUE);
sym->flags |= BSF_WEAK;
}

4
binutils/testsuite/binutils-all/objcopy.exp
View File

@ -1144,6 +1144,10 @@ proc objcopy_test_symbol_manipulation {} {
verbose [file rootname $t]
run_dump_test [file rootname $t]
}
if { [supports_gnu_unique] } {
run_dump_test "weaken-gnu-unique"
}
}
proc objcopy_test_elf_common_symbols {} {

8
binutils/testsuite/binutils-all/weaken-gnu-unique.d Normal file
View File

@ -0,0 +1,8 @@
#name: weaken STB_GNU_UNIQUE symbols
#PROG: objcopy
#objcopy: -W foo
#source: unique.s
#readelf: -s
#...
+[0-9]+: +[0-9a-f]+ +[0-9]+ +OBJECT +WEAK +DEFAULT +[1-9] foo