yggdrasil/binutils-gdb
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

sim: mips: call Unpredictable instead of setting bogus values [PR sim/29276]

Browse Source 
The intention of this code seems to be to indicate that this insn
should not be used and produces undefined behavior, so instead of
setting registers to bogus values, call Unpredictable.  This fixes
build warnings due to 32-bit/64-bit type conversions, and outputs
a log message for users at runtime instead of silent corruption.

Bug: https://sourceware.org/PR29276
This commit is contained in:
Mike Frysinger 2022-11-04 07:38:20 +07:00
parent 195064c8da
commit 2756004fe7
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
sim/mips/mips.igen
View File

@ -1450,7 +1450,7 @@
else if ((fs & 0x1) == 0)
GPR[rt] = SET64HI (FGR[fs+1]) | FGR[fs];
else
GPR[rt] = SET64HI (0xDEADC0DE) | 0xBAD0BAD0;
Unpredictable ();
TRACE_ALU_RESULT (GPR[rt]);
}
@ -5782,7 +5782,7 @@
else if ((FS & 0x1) == 0)
v = SET64HI (FGR[FS+1]) | FGR[FS];
else
v = SET64HI (0xDEADC0DE) | 0xBAD0BAD0;
Unpredictable ();
PENDING_FILL (RT, v);
TRACE_ALU_RESULT (v);
}