yggdrasil/binutils-gdb
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add some parallel_for_each tests

Browse Source 
Tom de Vries noticed that a patch in the DWARF scanner rewrite series
caused a regression in parallel_for_each -- it started crashing in the
case where the number of threads is 0 (there was an unchecked use of
"n-1" that was used to size an array).

He also pointed out that there were no tests of parallel_for_each.
This adds a few tests of parallel_for_each, primarily testing that
different settings for the number of threads will work.  This test
catches the bug that he found in that series.
This commit is contained in:
Tom Tromey 2021-08-28 13:16:50 -06:00
parent ee8b88452c
commit 282aa4f7d2
2 changed files with 87 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
gdb/Makefile.in
View File

@ -456,6 +456,7 @@ SELFTESTS_SRCS = \
unittests/offset-type-selftests.c \
unittests/observable-selftests.c \
unittests/optional-selftests.c \
unittests/parallel-for-selftests.c \
unittests/parse-connection-spec-selftests.c \
unittests/ptid-selftests.c \
unittests/main-thread-selftests.c \

86
gdb/unittests/parallel-for-selftests.c Normal file
View File

@ -0,0 +1,86 @@
/* Self tests for parallel_for_each
Copyright (C) 2021 Free Software Foundation, Inc.
This file is part of GDB.
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 3 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>. */
#include "defs.h"
#include "gdbsupport/selftest.h"
#include "gdbsupport/parallel-for.h"
#include "gdbsupport/thread-pool.h"
#if CXX_STD_THREAD
namespace selftests {
namespace parallel_for {
struct save_restore_n_threads
{
save_restore_n_threads ()
: n_threads (gdb::thread_pool::g_thread_pool->thread_count ())
{
}
~save_restore_n_threads ()
{
gdb::thread_pool::g_thread_pool->set_thread_count (n_threads);
}
int n_threads;
};
static void
test (int n_threads)
{
save_restore_n_threads saver;
gdb::thread_pool::g_thread_pool->set_thread_count (n_threads);
#define NUMBER 10000
std::atomic<int> counter = 0;
gdb::parallel_for_each (0, NUMBER,
[&] (int start, int end)
{
counter += end - start;
});
SELF_CHECK (counter == NUMBER);
#undef NUMBER
}
static void
test_n_threads ()
{
test (0);
test (1);
test (3);
}
}
}
#endif /* CXX_STD_THREAD */
void _initialize_parallel_for_selftests ();
void
_initialize_parallel_for_selftests ()
{
#ifdef CXX_STD_THREAD
selftests::register_test ("parallel_for",
selftests::parallel_for::test_n_threads);
#endif /* CXX_STD_THREAD */
}