yggdrasil/binutils-gdb
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Inconsistent .eh_frame_hdr on powerpc64

Browse Source 
There is code in bfd/elf-eh-frame.c and ld/emultempl/elf32.em that
checks for the presence of eh_frame info by testing for a section
named .eh_frame sized more than 8 bytes.   The size test is to exclude
a zero terminator.  A similar check in elf64-ppc.c wrongly just tested
for non-zero size before creating the linker generated .eh_frame
describing plt call and other linkage stubs.  The intention was to not
generate that info unless there was some user .eh_frame.  (No user
.eh_frame implies the user doesn't care about exception handling.)
Because the test in elf64-ppc.c was wrong, ld generated the stub
.eh_frame just on finding a zero .eh_frame terminator in crtend.o, but
didn't generate the corresponding .eh_frame_hdr.

	* elf64-ppc.c (ppc64_elf_size_stubs): Correct test for user
	.eh_frame info.
This commit is contained in:
Alan Modra 2017-11-14 11:02:57 +10:30
parent ddbb44cf36
commit 2d0d44d514
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
bfd/ChangeLog
View File

@ -1,3 +1,8 @@
2017-11-14 Alan Modra <amodra@gmail.com>
* elf64-ppc.c (ppc64_elf_size_stubs): Correct test for user
.eh_frame info.
2017-11-13 Jan Beulich <jbeulich@suse.com>
* coff-tic80.c (COFF_ENCODE_ALIGNMENT, COFF_DECODE_ALIGNMENT):

2
bfd/elf64-ppc.c
View File

@ -12700,7 +12700,7 @@ ppc64_elf_size_stubs (struct bfd_link_info *info)
if (htab->glink_eh_frame != NULL
&& !bfd_is_abs_section (htab->glink_eh_frame->output_section)
&& htab->glink_eh_frame->output_section->size != 0)
&& htab->glink_eh_frame->output_section->size > 8)
{
size_t size = 0, align = 4;