yggdrasil/binutils-gdb
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

gdb: clean up some inefficient std::string usage

Browse Source 
This commit:

  commit 53cf95c3389a3ecd97276d322e4a60fe3396a201
  Date:   Wed Dec 14 14:17:44 2022 +0000

      gdb: make more use of make_target_connection_string

Introduced a couple of inefficient uses of std::string, both of which
are fixed in this commit.

There should be no user visible changes after this commit.

Approved-By: Simon Marchi <simon.marchi@efficios.com>
This commit is contained in:
Andrew Burgess 2022-12-15 16:50:57 +00:00
parent fa501b6930
commit 38c0c0cac9
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
gdb/inferior.c
View File

@ -486,8 +486,7 @@ uiout_field_connection (process_stratum_target *proc_target)
return {};
else
{
std::string conn_str
= make_target_connection_string (proc_target).c_str ();
std::string conn_str = make_target_connection_string (proc_target);
return string_printf ("%d (%s)", proc_target->connection_number,
conn_str.c_str ());
}

2
gdb/target-connection.c
View File

@ -91,7 +91,7 @@ print_connection (struct ui_out *uiout, const char *requested_connections)
process_stratum_target *t = it.second;
size_t l = strlen (make_target_connection_string (t).c_str ());
size_t l = make_target_connection_string (t).length ();
if (l > what_len)
what_len = l;
}