yggdrasil/binutils-gdb
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

I caught a few mingw32-specific failures for some of the gdb.reverse

Browse Source 
tests.

FAIL: gdb.reverse/consecutive-precsave.exp: reload precord save file
FAIL: gdb.reverse/finish-precsave.exp: reload precord save file
FAIL: gdb.reverse/until-precsave.exp: reload core file
FAIL: gdb.reverse/watch-precsave.exp: reload core file
FAIL: gdb.reverse/step-precsave.exp: reload core file
FAIL: gdb.reverse/break-precsave.exp: reload precord save file
FAIL: gdb.reverse/sigall-precsave.exp: reload precord save file

They happen for two reasons.

- mingw32 does not define SIGTRAP, so upon recording a core file, the
signal information will be missing, which in turn causes GDB to not
display the stopping signal when it loads the same core file.  An
earlier message warns about this:

"warning: Signal SIGTRAP does not exist on this system."

- The testcase is crafted in a way that expects a pattern of the
stopping signal message instead of a successful core file read message.

The following patch fixes this by changing the old pattern to a more
reasonable one, while still ignoring the fact that mingw32-based GDB
does not record a SIGTRAP in a core file because it does not define
it.

gdb/testsuite/

2014-11-18  Luis Machado  <lgustavo@codesourcery.com>

	* gdb.reverse/break-precsave: Expect completion message for
	core file reads.
	* gdb.reverse/consecutive-precsave.exp: Likewise.
	* gdb.reverse/finish-precsave.exp: Likewise.
	* gdb.reverse/i386-precsave.exp: Likewise.
	* gdb.reverse/machinestate-precsave.exp: Likewise.
	* gdb.reverse/sigall-precsave.exp: Likewise.
	* gdb.reverse/solib-precsave.exp: Likewise.
	* gdb.reverse/step-precsave.exp: Likewise.
	* gdb.reverse/until-precsave.exp: Likewise.
	* gdb.reverse/watch-precsave.exp: Likewise.
This commit is contained in:
Luis Machado 2014-11-18 11:16:37 -02:00
parent ae527cd876
commit 470e2f4e30
11 changed files with 24 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
gdb/testsuite/ChangeLog
View File

@ -1,3 +1,17 @@
2014-11-18 Luis Machado <lgustavo@codesourcery.com>
* gdb.reverse/break-precsave: Expect completion message for
core file reads.
* gdb.reverse/consecutive-precsave.exp: Likewise.
* gdb.reverse/finish-precsave.exp: Likewise.
* gdb.reverse/i386-precsave.exp: Likewise.
* gdb.reverse/machinestate-precsave.exp: Likewise.
* gdb.reverse/sigall-precsave.exp: Likewise.
* gdb.reverse/solib-precsave.exp: Likewise.
* gdb.reverse/step-precsave.exp: Likewise.
* gdb.reverse/until-precsave.exp: Likewise.
* gdb.reverse/watch-precsave.exp: Likewise.
2014-11-17 Andreas Arnez <arnez@linux.vnet.ibm.com>
* gdb.base/bp-permanent.c: Include unistd.h.

2
gdb/testsuite/gdb.reverse/break-precsave.exp
View File

@ -58,7 +58,7 @@ proc precsave_tests {} {
"Kill the program being debugged\\? \\(y or n\\) " "y"
gdb_test "record restore $precsave" \
"Program terminated with signal .*" \
"Restored records from core file .*" \
"reload precord save file"
gdb_test "break foo" \

2
gdb/testsuite/gdb.reverse/consecutive-precsave.exp
View File

@ -50,7 +50,7 @@ gdb_test "kill" "" "Kill process, prepare to debug log file" \
"Kill the program being debugged\\? \\(y or n\\) " "y"
gdb_test "record restore $precsave" \
"Program terminated with signal .*" \
"Restored records from core file .*" \
"reload precord save file"
gdb_breakpoint foo

2
gdb/testsuite/gdb.reverse/finish-precsave.exp
View File

@ -51,7 +51,7 @@ gdb_test "kill" "" "Kill process, prepare to debug log file" \
"Kill the program being debugged\\? \\(y or n\\) " "y"
gdb_test "record restore $precsave" \
"Program terminated with signal .*" \
"Restored records from core file .*" \
"reload precord save file"
# Test finish from void func

2
gdb/testsuite/gdb.reverse/i386-precsave.exp
View File

@ -68,7 +68,7 @@ gdb_test "kill" "" "Kill process, prepare to debug log file" \
"Kill the program being debugged\\? \\(y or n\\) " "y"
gdb_test "record restore $precsave" \
"Program terminated with signal .*" \
"Restored records from core file .*" \
"reload precord save file"
gdb_test "step" "inc .eax.*" "step to inc eax 1st time"

2
gdb/testsuite/gdb.reverse/machinestate-precsave.exp
View File

@ -76,7 +76,7 @@ gdb_test "kill" "" "Kill process, prepare to debug log file" \
"Kill the program being debugged\\? \\(y or n\\) " "y"
gdb_test "record restore $precsave" \
"Program terminated with signal .*" \
"Restored records from core file .*" \
"reload prec save file"
# Proceed to end of main

2
gdb/testsuite/gdb.reverse/sigall-precsave.exp
View File

@ -278,7 +278,7 @@ gdb_test "kill" "" "Kill process, prepare to debug log file" \
"Kill the program being debugged\\? \\(y or n\\) " "y"
gdb_test "record restore $precsave" \
"Program terminated with signal .*" \
"Restored records from core file .*" \
"reload precord save file"
# Signal handlers must be re-enabled

2
gdb/testsuite/gdb.reverse/solib-precsave.exp
View File

@ -101,7 +101,7 @@ gdb_test "kill" "" "Kill process, prepare to debug log file" \
"Kill the program being debugged\\? \\(y or n\\) " "y"
gdb_test "record restore $precsave" \
"Program terminated with signal .*" \
"Restored records from core file .*" \
"reload core file"
#

2
gdb/testsuite/gdb.reverse/step-precsave.exp
View File

@ -54,7 +54,7 @@ gdb_test "kill" "" "Kill process, prepare to debug log file" \
"Kill the program being debugged\\? \\(y or n\\) " "y"
gdb_test "record restore $precsave" \
"Program terminated with signal .*" \
"Restored records from core file .*" \
"reload core file"
# plain vanilla step/next (no count)

2
gdb/testsuite/gdb.reverse/until-precsave.exp
View File

@ -70,7 +70,7 @@ gdb_test "kill" "" "Kill process, prepare to debug log file" \
"Kill the program being debugged\\? \\(y or n\\) " "y"
gdb_test "record restore $precsave" \
"Program terminated with signal .*" \
"Restored records from core file .*" \
"reload core file"
# Verify that plain vanilla "until <location>" works.

2
gdb/testsuite/gdb.reverse/watch-precsave.exp
View File

@ -51,7 +51,7 @@ gdb_test "kill" "" "Kill process, prepare to debug log file" \
"Kill the program being debugged\\? \\(y or n\\) " "y"
gdb_test "record restore $precsave" \
"Program terminated with signal .*" \
"Restored records from core file .*" \
"reload core file"
# Only software watchpoints can be used in reverse