yggdrasil/binutils-gdb
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Re-fix leak in source.c (open_source_file).

Browse Source 
Leak fixed in '8e6a5953e1d Fix 4K leak in open_source_file' has been partially
undone by '2179fbc36d23 Return scoped_fd from open_source_file'. Re-add the
transfer of current s->fullname to the unique_xmalloc_ptr fullname given to
find_and_open_source.
This commit is contained in:
Philippe Waroquiers 2018-11-24 12:42:24 +01:00
parent f5e0fe29ee
commit 5446094655
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
gdb/ChangeLog
View File

@ -1,3 +1,11 @@
2018-11-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
* source.c (open_source_file): Leak fixed in '8e6a5953e1d Fix 4K
leak in open_source_file' has been partially undone by '2179fbc36d23
Return scoped_fd from open_source_file'. Re-add the transfer of
current s->fullname to the unique_xmalloc_ptr fullname given
to find_and_open_source.
2018-11-23 Pedro Alves <palves@redhat.com>
* gdbthread.h (enum thread_state): Move comments here.

2
gdb/source.c
View File

@ -1068,7 +1068,7 @@ open_source_file (struct symtab *s)
if (!s)
return scoped_fd (-1);
gdb::unique_xmalloc_ptr<char> fullname;
gdb::unique_xmalloc_ptr<char> fullname (s->fullname);
s->fullname = NULL;
scoped_fd fd = find_and_open_source (s->filename, SYMTAB_DIRNAME (s),
&fullname);