yggdrasil/binutils-gdb
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Re: comdat_hash memory leaks

Browse Source 
I missed another field that needs freeing.  Also, oss-fuzz found a
case with a C_FILE sym using multiple auxents for a long file name
which overflowed the single auxent buffer.  I'm going to fix that
problem in swap_aux_in too, but we may as well avoid it here too,
saving unnecessary work.

	* coffcode.h (comdat_delf): Free comdat_name.
	(fill_comdat_hash): Only look at symbols with one auxent.
This commit is contained in:
Alan Modra 2023-08-28 20:53:02 +09:30
parent f5362c933e
commit 54d57acf61
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
bfd/coffcode.h
View File

@ -872,6 +872,7 @@ static void
comdat_delf (void *ent)
{
struct comdat_hash_entry *e = ent;
free (e->comdat_name);
free (e->symname);
free (e);
}
@ -964,7 +965,7 @@ fill_comdat_hash (bfd *abfd)
if (*slot == NULL)
{
if (isym.n_numaux == 0)
if (isym.n_numaux != 1)
aux.x_scn.x_comdat = 0;
else
{