yggdrasil/binutils-gdb
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

gdbserver: turn target op 'handle_monitor_command' into a method

Browse Source 
gdbserver/ChangeLog:
2020-02-20  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>

	Turn process_stratum_target's handle_monitor_command op into a
	method of process_target.

	* target.h (struct process_stratum_target): Remove the target op.
	(class process_target): Add the target op.
	(target_handle_monitor_command): Update the macro.
	* target.cc (process_target::handle_monitor_command): Define.

	Update the derived classes and callers below.

	* server.cc (handle_query): Update.
	* linux-low.cc (linux_target_ops): Update.
	(linux_process_target::handle_monitor_command): Define.
	* linux-low.h (class linux_process_target): Update.
	* lynx-low.cc (lynx_target_ops): Update.
	* nto-low.cc (nto_target_ops): Update.
	* win32-low.cc (win32_target_ops): Update.
This commit is contained in:
Tankut Baris Aktemur 2020-02-17 16:11:58 +01:00
parent fb00dfcef0
commit 55cf302157
9 changed files with 43 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
gdbserver/ChangeLog
View File

@ -1,3 +1,23 @@
2020-02-20 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
Turn process_stratum_target's handle_monitor_command op into a
method of process_target.
* target.h (struct process_stratum_target): Remove the target op.
(class process_target): Add the target op.
(target_handle_monitor_command): Update the macro.
* target.cc (process_target::handle_monitor_command): Define.
Update the derived classes and callers below.
* server.cc (handle_query): Update.
* linux-low.cc (linux_target_ops): Update.
(linux_process_target::handle_monitor_command): Define.
* linux-low.h (class linux_process_target): Update.
* lynx-low.cc (lynx_target_ops): Update.
* nto-low.cc (nto_target_ops): Update.
* win32-low.cc (win32_target_ops): Update.
2020-02-20 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
Turn process_stratum_target's handle_new_gdb_connection op into a

15
gdbserver/linux-low.cc
View File

@ -6398,6 +6398,16 @@ linux_process_target::handle_new_gdb_connection ()
});
}
int
linux_process_target::handle_monitor_command (char *mon)
{
#ifdef USE_THREAD_DB
return thread_db_handle_monitor_command (mon);
#else
return 0;
#endif
}
static int
linux_supports_disable_randomization (void)
{
@ -7429,11 +7439,6 @@ linux_get_hwcap2 (int wordsize)
static linux_process_target the_linux_target;
static process_stratum_target linux_target_ops = {
#ifdef USE_THREAD_DB
thread_db_handle_monitor_command,
#else
NULL,
#endif
linux_common_core_of_thread,
linux_read_loadmap,
linux_process_qsupported,

2
gdbserver/linux-low.h
View File

@ -373,6 +373,8 @@ public:
bool supports_exec_events () override;
void handle_new_gdb_connection () override;
int handle_monitor_command (char *mon) override;
};
#define get_thread_lwp(thr) ((struct lwp_info *) (thread_target_data (thr)))

1
gdbserver/lynx-low.cc
View File

@ -735,7 +735,6 @@ static lynx_process_target the_lynx_target;
/* The LynxOS target_ops vector. */
static process_stratum_target lynx_target_ops = {
NULL, /* handle_monitor_command */
NULL, /* core_of_thread */
NULL, /* read_loadmap */
NULL, /* process_qsupported */

1
gdbserver/nto-low.cc
View File

@ -947,7 +947,6 @@ nto_sw_breakpoint_from_kind (int kind, int *size)
static nto_process_target the_nto_target;
static process_stratum_target nto_target_ops = {
NULL, /* handle_monitor_command */
NULL, /* core_of_thread */
NULL, /* read_loadmap */
NULL, /* process_qsupported */

3
gdbserver/server.cc
View File

@ -2577,8 +2577,7 @@ handle_query (char *own_buf, int packet_len, int *new_packet_len_p)
write_ok (own_buf);
if (the_target->handle_monitor_command == NULL
|| (*the_target->handle_monitor_command) (mon) == 0)
if (the_target->pt->handle_monitor_command (mon) == 0)
/* Default processing. */
handle_monitor_command (mon, own_buf);

6
gdbserver/target.cc
View File

@ -577,3 +577,9 @@ process_target::handle_new_gdb_connection ()
{
/* Nop. */
}
int
process_target::handle_monitor_command (char *mon)
{
return 0;
}

8
gdbserver/target.h
View File

@ -70,10 +70,6 @@ class process_target;
shared code. */
struct process_stratum_target
{
/* If not NULL, target-specific routine to process monitor command.
Returns 1 if handled, or 0 to perform default processing. */
int (*handle_monitor_command) (char *);
/* Returns the core given a thread, or -1 if not known. */
int (*core_of_thread) (ptid_t);
@ -486,6 +482,10 @@ public:
/* Allows target to re-initialize connection-specific settings. */
virtual void handle_new_gdb_connection ();
/* The target-specific routine to process monitor command.
Returns 1 if handled, or 0 to perform default processing. */
virtual int handle_monitor_command (char *mon);
};
extern process_stratum_target *the_target;

1
gdbserver/win32-low.cc
View File

@ -1852,7 +1852,6 @@ win32_sw_breakpoint_from_kind (int kind, int *size)
static win32_process_target the_win32_target;
static process_stratum_target win32_target_ops = {
NULL, /* handle_monitor_command */
NULL, /* core_of_thread */
NULL, /* read_loadmap */
NULL, /* process_qsupported */