yggdrasil/binutils-gdb
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

asan: csky floatformat_to_double uninitialised value

Browse Source 
* csky-dis.c (csky_print_operand <OPRND_TYPE_FCONSTANT>): Don't
	access ibytes after read_memory_func error.  Change type of
	ibytes to avoid casts.
This commit is contained in:
Alan Modra 2023-04-03 12:35:53 +09:30
parent 29caf11836
commit 5cdf86d363
1 changed files with 6 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
opcodes/csky-dis.c
View File

@ -519,7 +519,7 @@ csky_output_operand (char *str, struct operand const *oprnd,
case OPRND_TYPE_FCONSTANT:
{
int shift = oprnd->shift;
char ibytes[8];
bfd_byte ibytes[8];
int status;
bfd_vma addr;
int nbytes;
@ -538,19 +538,13 @@ csky_output_operand (char *str, struct operand const *oprnd,
else
nbytes = 4;
status = dis_info.info->read_memory_func (addr, (bfd_byte *)ibytes,
status = dis_info.info->read_memory_func (addr, ibytes,
nbytes, dis_info.info);
if (status != 0)
/* Address out of bounds. -> lrw rx, [pc, 0ffset]. */
sprintf (buf, "[pc, %d]\t// from address pool at %x", (int)value,
(unsigned int)addr);
else
{
dis_info.value = addr;
value = csky_chars_to_number ((unsigned char *)ibytes, 4);
}
if (oprnd->type == OPRND_TYPE_FCONSTANT)
else if (oprnd->type == OPRND_TYPE_FCONSTANT)
{
double f;
@ -569,8 +563,10 @@ csky_output_operand (char *str, struct operand const *oprnd,
}
else
{
dis_info.value = addr;
dis_info.need_output_symbol = 1;
sprintf (buf, "0x%x", (unsigned int)value);
value = csky_chars_to_number (ibytes, 4);
sprintf (buf, "0x%x", (unsigned int) value);
}
strcat (str, buf);