yggdrasil/binutils-gdb
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix breakpoint commands in MI.

Browse Source 
* mi/mi-main.c (mi_execute_command): Run bpstat_do_actions.
	* mi/mi-cmd-break.c (mi_cmd_break_commands): Pass 1 to
	read_command_line_1 to actually parse composite commands.
This commit is contained in:
Vladimir Prus 2009-10-30 17:34:53 +00:00
parent b6cdf8aeed
commit 5d4e2b767e
5 changed files with 32 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
gdb/ChangeLog
View File

@ -1,3 +1,11 @@
2009-10-30 Vladimir Prus <vladimir@codesourcery.com>
Fix breakpoint commands in MI.
* mi/mi-main.c (mi_execute_command): Run bpstat_do_actions.
* mi/mi-cmd-break.c (mi_cmd_break_commands): Pass 1 to
read_command_line_1 to actually parse composite commands.
2009-10-29 Sandra Loosemore <sandra@codesourcery.com> 2009-10-29 Sandra Loosemore <sandra@codesourcery.com>
PR gdb/10783 PR gdb/10783

2
gdb/mi/mi-cmd-break.c
View File

@ -298,7 +298,7 @@ mi_cmd_break_commands (char *command, char **argv, int argc)
mi_command_line_array_ptr = 1; mi_command_line_array_ptr = 1;
mi_command_line_array_cnt = argc; mi_command_line_array_cnt = argc;
break_command = read_command_lines_1 (mi_read_next_line, 0); break_command = read_command_lines_1 (mi_read_next_line, 1);
breakpoint_set_commands (b, break_command); breakpoint_set_commands (b, break_command);
} }

2
gdb/mi/mi-main.c
View File

@ -1306,6 +1306,8 @@ mi_execute_command (char *cmd, int from_tty)
mi_out_rewind (uiout); mi_out_rewind (uiout);
} }
bpstat_do_actions ();
if (/* The notifications are only output when the top-level if (/* The notifications are only output when the top-level
interpreter (specified on the command line) is MI. */ interpreter (specified on the command line) is MI. */
ui_out_is_mi_like_p (interp_ui_out (top_level_interpreter ())) ui_out_is_mi_like_p (interp_ui_out (top_level_interpreter ()))

6
gdb/testsuite/ChangeLog
View File

@ -1,3 +1,9 @@
2009-10-30 Vladimir Prus <vladimir@codesourcery.com>
* gdb.mi/mi-break.exp (test_breakpoint_commands): Test
that composite commands are parsed OK. And also test
that breakpoint commands do work.
2009-10-23 Michael Snyder <msnyder@vmware.com> 2009-10-23 Michael Snyder <msnyder@vmware.com>
gdb.reverse/consecutive-precsave.exp: Change expect pattern gdb.reverse/consecutive-precsave.exp: Change expect pattern

15
gdb/testsuite/gdb.mi/mi-break.exp
View File

@ -219,6 +219,21 @@ proc test_breakpoint_commands {} {
mi_list_breakpoints [list [list 7 "keep" "callee2" "basics.c" "$line_callee2_body" $hex]] \ mi_list_breakpoints [list [list 7 "keep" "callee2" "basics.c" "$line_callee2_body" $hex]] \
"breakpoint commands: check that commands are cleared" "breakpoint commands: check that commands are cleared"
mi_run_to_main
mi_create_breakpoint "basics.c:callee2" 9 keep callee2 ".*basics.c" $line_callee2_body $hex \
"breakpoint commands: insert breakpoint at basics.c:callee2, again"
mi_gdb_test "-break-commands 9 \"set \$i=0\" \"while \$i<10\" \"print \$i\" \"set \$i=\$i+1\" \"end\" \"continue\" " \
"\\^done" \
"breakpoint commands: set commands"
mi_gdb_test "-exec-continue" \
".*\\\$1 = 0.*\\\$10 = 9.*\\*running.*\\*stopped,reason=\"exited-normally\".*" \
"test hitting breakpoint with commands"
} }
test_tbreak_creation_and_listing test_tbreak_creation_and_listing