yggdrasil/binutils-gdb
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

* buildsym.c (record_line): Remove empty lines followed by

Browse Source 
end-of-sequence markers.
This commit is contained in:
Daniel Jacobowitz 2007-10-11 17:38:59 +00:00
parent ad4b42b49f
commit 607ae575a7
2 changed files with 31 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gdb/ChangeLog
View File

@ -1,3 +1,8 @@
2007-10-11 Daniel Jacobowitz <dan@codesourcery.com>
* buildsym.c (record_line): Remove empty lines followed by
end-of-sequence markers.
2007-10-11 Kazu Hirata <kazu@codesourcery.com> 2007-10-11 Kazu Hirata <kazu@codesourcery.com>
* configure.tgt: Recognize fido-*-elf. * configure.tgt: Recognize fido-*-elf.

27
gdb/buildsym.c
View File

@ -752,9 +752,34 @@ record_line (struct subfile *subfile, int line, CORE_ADDR pc)
* sizeof (struct linetable_entry)))); * sizeof (struct linetable_entry))));
} }
pc = gdbarch_addr_bits_remove (current_gdbarch, pc);
/* Normally, we treat lines as unsorted. But the end of sequence
marker is special. We sort line markers at the same PC by line
number, so end of sequence markers (which have line == 0) appear
first. This is right if the marker ends the previous function,
and there is no padding before the next function. But it is
wrong if the previous line was empty and we are now marking a
switch to a different subfile. We must leave the end of sequence
marker at the end of this group of lines, not sort the empty line
to after the marker. The easiest way to accomplish this is to
delete any empty lines from our table, if they are followed by
end of sequence markers. All we lose is the ability to set
breakpoints at some lines which contain no instructions
anyway. */
if (line == 0 && subfile->line_vector->nitems > 0)
{
e = subfile->line_vector->item + subfile->line_vector->nitems - 1;
while (subfile->line_vector->nitems > 0 && e->pc == pc)
{
e--;
subfile->line_vector->nitems--;
}
}
e = subfile->line_vector->item + subfile->line_vector->nitems++; e = subfile->line_vector->item + subfile->line_vector->nitems++;
e->line = line; e->line = line;
e->pc = gdbarch_addr_bits_remove (current_gdbarch, pc); e->pc = pc;
} }
/* Needed in order to sort line tables from IBM xcoff files. Sigh! */ /* Needed in order to sort line tables from IBM xcoff files. Sigh! */