Fix PR gdb/14617.
	* breakpoint.c (trace_pass_set_count): Call
	observer_notify_breakpoint_modified instead of
	observer_notify_tracepoint_modified.
	* mi/mi-cmd-break.c (mi_cmd_break_passcount): Likewise.

gdb/doc:

	* observer.texi (GDB Observers): Remove observer
	'tracepoint_modified', 'tracepoint_created' and
	'tracepoint_deleted'.

gdb/testsuite:

	Fix PR gdb/14617.
	* gdb.mi/mi-breakpoint-changed.exp (test_insert_delete_modify):
	Remove setup_kfail, and update test.
This commit is contained in:
Yao Qi 2012-11-03 12:14:47 +00:00
parent 2036af69e1
commit 6f6484cd83
7 changed files with 23 additions and 19 deletions

View File

@ -1,3 +1,11 @@
2012-11-03 Yao Qi <yao@codesourcery.com>
Fix PR gdb/14617.
* breakpoint.c (trace_pass_set_count): Call
observer_notify_breakpoint_modified instead of
observer_notify_tracepoint_modified.
* mi/mi-cmd-break.c (mi_cmd_break_passcount): Likewise.
2012-11-02 Tom Tromey <tromey@redhat.com>
* breakpoint.c (catch_syscall_completer): Pass 'word' as second

View File

@ -15245,7 +15245,7 @@ static void
trace_pass_set_count (struct tracepoint *tp, int count, int from_tty)
{
tp->pass_count = count;
observer_notify_tracepoint_modified (tp->base.number);
observer_notify_breakpoint_modified (&tp->base);
if (from_tty)
printf_filtered (_("Setting tracepoint %d's passcount to %d\n"),
tp->base.number, count);

View File

@ -1,3 +1,9 @@
2012-11-03 Yao Qi <yao@codesourcery.com>
* observer.texi (GDB Observers): Remove observer
'tracepoint_modified', 'tracepoint_created' and
'tracepoint_deleted'.
2012-10-26 Tom Tromey <tromey@redhat.com>
* gdb.texinfo (General Query Packets): Use @itemx for QAgent.

View File

@ -179,21 +179,6 @@ A breakpoint has been modified in some way. The argument @var{b}
is the modified breakpoint.
@end deftypefun
@deftypefun void tracepoint_created (int @var{tpnum})
A new tracepoint has been created. The argument @var{tpnum} is the
number of the newly-created tracepoint.
@end deftypefun
@deftypefun void tracepoint_deleted (int @var{tpnum})
A tracepoint has been destroyed. The argument @var{tpnum} is the
number of the newly-destroyed tracepoint.
@end deftypefun
@deftypefun void tracepoint_modified (int @var{tpnum})
A tracepoint has been modified in some way. The argument @var{tpnum}
is the number of the modified tracepoint.
@end deftypefun
@deftypefun void traceframe_changed (int @var{tfnum}, int @var{tpnum})
The trace frame is changed to @var{tfnum} (e.g., by using the
@code{tfind} command). If @var{tfnum} is negative, it means

View File

@ -200,7 +200,7 @@ mi_cmd_break_passcount (char *command, char **argv, int argc)
if (t)
{
t->pass_count = p;
observer_notify_tracepoint_modified (n);
observer_notify_breakpoint_modified (&t->base);
}
else
{

View File

@ -1,3 +1,9 @@
2012-11-03 Yao Qi <yao@codesourcery.com>
Fix PR gdb/14617.
* gdb.mi/mi-breakpoint-changed.exp (test_insert_delete_modify):
Remove setup_kfail, and update test.
2012-11-02 Tom Tromey <tromey@redhat.com>
* gdb.base/catch-syscall.exp (do_syscall_tests): Add completion

View File

@ -120,10 +120,9 @@ proc test_insert_delete_modify { } {
{.*=breakpoint-modified,bkpt=\{number="5",.*,ignore=\"1\".*\}.*\n\^done} \
$test
# 5. when modifying pass count.
setup_kfail gdb/14617 *-*-*
set test "passcount 1 4"
mi_gdb_test $test \
{.*=breakpoint-modified,bkpt=\{number="4",.*\}.*\n\^done} \
{.*=breakpoint-modified,bkpt=\{number="4",.*pass="1".*\}.*\n\^done} \
$test
# Delete some breakpoints and verify that '=breakpoint-deleted