yggdrasil/binutils-gdb
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ld insert_os_after ignoring first assignment

Browse Source 
Some time ago the pr19593 test was xfailed for alpha.  This turned out
to be the wrong course of action since the test exposed a bug in
orphan section placement.  On alpha, orphan sections were being
inserted before ". = SIZEOF_HEADERS" due to the test having two
assignments, and on alpha, an output section statement from
-Ttext-segment being passed to ld.

	* ldlang.c (insert_os_after): Clear ignore_first on assignment to
	dot, not any assignment.  Clear ignore_first on output section
	statement contents too.
	* testsuite/ld-elf/pr19539.d: Remove alpha xfail.
This commit is contained in:
Alan Modra 2018-10-08 08:44:50 +10:30
parent 5d69562788
commit 7358942661
3 changed files with 15 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
ld/ChangeLog
View File

@ -1,3 +1,10 @@
2018-10-08 Alan Modra <amodra@gmail.com>
* ldlang.c (insert_os_after): Clear ignore_first on assignment to
dot, not any assignment. Clear ignore_first on output section
statement contents too.
* testsuite/ld-elf/pr19539.d: Remove alpha xfail.
2018-10-08 Alan Modra <amodra@gmail.com> 2018-10-08 Alan Modra <amodra@gmail.com>
* testsuite/ld-elf/pr22423.d: Pass --dynamic-linker to ld. * testsuite/ld-elf/pr22423.d: Pass --dynamic-linker to ld.

11
ld/ldlang.c
View File

@ -1777,11 +1777,13 @@ insert_os_after (lang_output_section_statement_type *after)
ass = &(*where)->assignment_statement; ass = &(*where)->assignment_statement;
if (ass->exp->type.node_class != etree_assert if (ass->exp->type.node_class != etree_assert
&& ass->exp->assign.dst[0] == '.' && ass->exp->assign.dst[0] == '.'
&& ass->exp->assign.dst[1] == 0 && ass->exp->assign.dst[1] == 0)
&& !ignore_first) {
assign = where; if (!ignore_first)
assign = where;
ignore_first = FALSE;
}
} }
ignore_first = FALSE;
continue; continue;
case lang_wild_statement_enum: case lang_wild_statement_enum:
case lang_input_section_enum: case lang_input_section_enum:
@ -1792,6 +1794,7 @@ insert_os_after (lang_output_section_statement_type *after)
case lang_padding_statement_enum: case lang_padding_statement_enum:
case lang_constructors_statement_enum: case lang_constructors_statement_enum:
assign = NULL; assign = NULL;
ignore_first = FALSE;
continue; continue;
case lang_output_section_statement_enum: case lang_output_section_statement_enum:
if (assign != NULL) if (assign != NULL)

2
ld/testsuite/ld-elf/pr19539.d
View File

@ -3,7 +3,7 @@
#ld: -pie -T pr19539.t #ld: -pie -T pr19539.t
#readelf : --dyn-syms --wide #readelf : --dyn-syms --wide
#target: *-*-linux* *-*-gnu* *-*-solaris* arm*-*-uclinuxfdpiceabi #target: *-*-linux* *-*-gnu* *-*-solaris* arm*-*-uclinuxfdpiceabi
#xfail: cris*-*-* alpha-*-* #xfail: cris*-*-*
Symbol table '\.dynsym' contains [0-9]+ entr(y|ies): Symbol table '\.dynsym' contains [0-9]+ entr(y|ies):
#pass #pass