yggdrasil/binutils-gdb
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

PR29189, dlltool delaylibs corrupt float/double arguments

Browse Source 
PR 29189
	* dlltool.c (i386_x64_trampoline): Save and restore xmm0-5.  Make
	use of parameter save area for integer arg regs.  Comment.
This commit is contained in:
Alan Modra 2023-05-15 10:44:29 +09:30
parent 7ea5b1997a
commit 7529ff1fcd
1 changed files with 39 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

52
binutils/dlltool.c
View File

@ -583,22 +583,48 @@ static const char i386_trampoline[] =
"\tpopl %%ecx\n"
"\tjmp *%%eax\n";
/* Save integer arg regs in parameter space reserved by our caller
above the return address. Allocate space for six fp arg regs plus
parameter space possibly used by __delayLoadHelper2 plus alignment.
We enter with the stack offset from 16-byte alignment by the return
address, so allocate 96 + 32 + 8 = 136 bytes. Note that only the
first four xmm regs are used to pass fp args, but the first six
vector ymm (zmm too?) are used to pass vector args. We are
assuming that volatile vector regs are not modified inside
__delayLoadHelper2. However, it is known that at least xmm0 and
xmm1 are trashed in some versions of Microsoft dlls, and if xmm4 or
xmm5 are also used then that would trash the lower bits of ymm4 and
ymm5. If it turns out that vector insns with a vex prefix are used
then we'll need to save ymm0-5 here but that can't be done without
first testing cpuid and xcr0. */
static const char i386_x64_trampoline[] =
"\tsubq $72, %%rsp\n"
"\t.seh_stackalloc 72\n"
"\tsubq $136, %%rsp\n"
"\t.seh_stackalloc 136\n"
"\t.seh_endprologue\n"
"\tmovq %%rcx, 64(%%rsp)\n"
"\tmovq %%rdx, 56(%%rsp)\n"
"\tmovq %%r8, 48(%%rsp)\n"
"\tmovq %%r9, 40(%%rsp)\n"
"\tmovq %%rax, %%rdx\n"
"\tleaq __DELAY_IMPORT_DESCRIPTOR_%s(%%rip), %%rcx\n"
"\tmovq %%rcx, 136+8(%%rsp)\n"
"\tmovq %%rdx, 136+16(%%rsp)\n"
"\tmovq %%r8, 136+24(%%rsp)\n"
"\tmovq %%r9, 136+32(%%rsp)\n"
"\tmovaps %%xmm0, 32(%%rsp)\n"
"\tmovaps %%xmm1, 48(%%rsp)\n"
"\tmovaps %%xmm2, 64(%%rsp)\n"
"\tmovaps %%xmm3, 80(%%rsp)\n"
"\tmovaps %%xmm4, 96(%%rsp)\n"
"\tmovaps %%xmm5, 112(%%rsp)\n"
"\tmovq %%rax, %%rdx\n"
"\tleaq __DELAY_IMPORT_DESCRIPTOR_%s(%%rip), %%rcx\n"
"\tcall __delayLoadHelper2\n"
"\tmovq 40(%%rsp), %%r9\n"
"\tmovq 48(%%rsp), %%r8\n"
"\tmovq 56(%%rsp), %%rdx\n"
"\tmovq 64(%%rsp), %%rcx\n"
"\taddq $72, %%rsp\n"
"\tmovq 136+8(%%rsp), %%rcx\n"
"\tmovq 136+16(%%rsp), %%rdx\n"
"\tmovq 136+24(%%rsp), %%r8\n"
"\tmovq 136+32(%%rsp), %%r9\n"
"\tmovaps 32(%%rsp), %%xmm0\n"
"\tmovaps 48(%%rsp), %%xmm1\n"
"\tmovaps 64(%%rsp), %%xmm2\n"
"\tmovaps 80(%%rsp), %%xmm3\n"
"\tmovaps 96(%%rsp), %%xmm4\n"
"\tmovaps 112(%%rsp), %%xmm5\n"
"\taddq $136, %%rsp\n"
"\tjmp *%%rax\n";
struct mac