yggdrasil/binutils-gdb
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mmo.c leak in mmo_make_section

Browse Source 
* mmo.c (mmo_make_section): Alloc name using bfd_alloc.  Use
	bfd_error_no_memory.
	(mmo_decide_section): Check for NULL return from mmo_make_section.
This commit is contained in:
Alan Modra 2022-08-17 15:48:21 +09:30
parent 2bda15d73c
commit 7a1bc25b9d
1 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
bfd/mmo.c
View File

@ -463,17 +463,15 @@ mmo_make_section (bfd *abfd, const char *secname)
if (sec == NULL)
{
char *newsecname = strdup (secname);
size_t len = strlen (secname) + 1;
char *newsecname = bfd_alloc (abfd, len);
if (newsecname == NULL)
{
_bfd_error_handler
/* xgettext:c-format */
(_("%pB: no core to allocate section name %s"),
abfd, secname);
bfd_set_error (bfd_error_system_call);
bfd_set_error (bfd_error_no_memory);
return NULL;
}
memcpy (newsecname, secname, len);
sec = bfd_make_section (abfd, newsecname);
}
@ -727,7 +725,7 @@ mmo_decide_section (bfd *abfd, bfd_vma vma)
sprintf (sec_name, ".MMIX.sec.%d", abfd->tdata.mmo_data->sec_no++);
sec = mmo_make_section (abfd, sec_name);
if (!sec->user_set_vma && !bfd_set_section_vma (sec, vma))
if (!sec || (!sec->user_set_vma && !bfd_set_section_vma (sec, vma)))
return NULL;
if (!bfd_set_section_flags (sec, (bfd_section_flags (sec)