yggdrasil/binutils-gdb
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Prevent an assertion from being triggered when linking an ARM object file with incorrectly set build attributes.

Browse Source 
PR 28848
	PR 28859
	* elf32-arm.c (elf32_arm_merge_eabi_attributes): If the first
	input bfd has a Tag_ABI_HardFP_use set to 3 but does not also have
	TAG_FP_arch set then reset the TAG_ABI_HardFP_use.
This commit is contained in:
Nick Clifton 2022-03-01 09:51:59 +00:00
parent 1dbf27133d
commit 81c9e0f6c4
2 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
bfd/ChangeLog
View File

@ -1,3 +1,10 @@
2022-03-01 Nick Clifton <nickc@redhat.com>
PR 28848
* elf32-arm.c (elf32_arm_merge_eabi_attributes): If the first
input bfd has a Tag_ABI_HardFP_use set to 3 but does not also have
TAG_FP_arch set then reset the TAG_ABI_HardFP_use.
2022-02-28 Torbjörn Svensson <torbjorn.svensson@st.com>
PR 25713

8
bfd/elf32-arm.c
View File

@ -14523,6 +14523,14 @@ elf32_arm_merge_eabi_attributes (bfd *ibfd, struct bfd_link_info *info)
out_attr[Tag_MPextension_use_legacy].i = 0;
}
/* PR 28859 and 28848: Handle the case where the first input file,
eg crti.o, has a Tag_ABI_HardFP_use of 3 but no Tag_FP_arch set.
Using Tag_ABI_HardFP_use in this way is deprecated, so reset the
attribute to zero.
FIXME: Should we handle other non-zero values of Tag_ABI_HardFO_use ? */
if (out_attr[Tag_ABI_HardFP_use].i == 3 && out_attr[Tag_FP_arch].i == 0)
out_attr[Tag_ABI_HardFP_use].i = 0;
return result;
}