yggdrasil/binutils-gdb
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

PR25081, Discrepancy between VMA and LMA after ALIGN

Browse Source 
The testcase in the PR has two empty output sections, .sec1 with an
ALIGN and symbol assignment, and .sec2 just with an empty input
section.  The symbol assignment results in .sec1 being kept, but
because it is empty this section doesn't take space from the memory
region as you might expect from the ALIGN.  Instead the next section
.sec2, has vma/lma as if .sec1 wasn't present.  However, .sec2 is
discarded and os->ignored set, which unfortunately meant that dot
wasn't set from .sec2 vma.  That in turn results in .sec2 lma being
set incorrectly.  That vma/lma difference is then propagated to
.sec3 where it is seen as an overlap.

	PR 25081
	* ldlang.c (lang_size_sections_1): Set lma from section vma
	rather than dot.
This commit is contained in:
Alan Modra 2019-10-09 21:25:25 +10:30
parent 6d9d6da48e
commit 8610e0fd93
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
ld/ChangeLog
View File

@ -1,3 +1,9 @@
2019-10-09 Alan Modra <amodra@gmail.com>
PR 25081
* ldlang.c (lang_size_sections_1): Set lma from section vma
rather than dot.
2019-10-08 Alan Modra <amodra@gmail.com>
* testsuite/ld-powerpc/localgot.s,

2
ld/ldlang.c
View File

@ -5691,7 +5691,7 @@ lang_size_sections_1
/* Otherwise, keep the same lma to vma relationship
as the previous section. */
else
lma = dot + last->lma - last->vma;
lma = os->bfd_section->vma + last->lma - last->vma;
if (section_alignment > 0)
lma = align_power (lma, section_alignment);