yggdrasil/binutils-gdb
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix an attempt to allocate an excessive amount of memory when parsing a corrupt DWARF file.

Browse Source 
PR 30313
  * dwarf.c (display_debug_lines_decoded): Check for an overlarge number of files or directories.
This commit is contained in:
Nick Clifton 2023-04-11 16:14:23 +01:00
parent 688fe114cd
commit 9f1c612b7c
2 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
binutils/ChangeLog
View File

@ -1,5 +1,9 @@
2023-04-11 Nick Clifton <nickc@redhat.com>
PR 30313
* dwarf.c (display_debug_lines_decoded): Check for an overlarge
number of files or directories.
PR 30312
* dwarf.c (prealloc_cu_tu_list): Always allocate at least one
entry.

13
binutils/dwarf.c
View File

@ -4997,6 +4997,12 @@ display_debug_lines_decoded (struct dwarf_section * section,
if (n_directories == 0)
directory_table = NULL;
else if (n_directories > section->size)
{
warn (_("number of directories (0x%x) exceeds size of section %s\n"),
n_directories, section->name);
return 0;
}
else
directory_table = (char **)
xcalloc (n_directories, sizeof (unsigned char *));
@ -5055,6 +5061,7 @@ display_debug_lines_decoded (struct dwarf_section * section,
if (do_checks && format_count > 5)
warn (_("Unexpectedly large number of columns in the file name table (%u)\n"),
format_count);
format_start = data;
for (formati = 0; formati < format_count; formati++)
{
@ -5071,6 +5078,12 @@ display_debug_lines_decoded (struct dwarf_section * section,
if (n_files == 0)
file_table = NULL;
else if (n_files > section->size)
{
warn (_("number of files (0x%x) exceeds size of section %s\n"),
n_files, section->name);
return 0;
}
else
file_table = (File_Entry *) xcalloc (n_files,
sizeof (File_Entry));