yggdrasil/binutils-gdb
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[gdb/build] Fix gdbserver build with -fsanitize=thread

Browse Source 
[ Copied from gcc commit 153689603fd ("[gdb/build] Fix gdbserver build with
-fsanitize=thread"). ]

When building gdbserver with -fsanitize=thread (added to CFLAGS/CXXFLAGS) we
run into:
...
ld: ../libiberty/libiberty.a(safe-ctype.o): warning: relocation against \
  `__tsan_init' in read-only section `.text'
ld: ../libiberty/libiberty.a(safe-ctype.o): relocation R_X86_64_PC32 \
  against symbol `__tsan_init' can not be used when making a shared object; \
  recompile with -fPIC
ld: final link failed: bad value
collect2: error: ld returned 1 exit status
make[1]: *** [libinproctrace.so] Error 1
...
which looks similar to what is described in commit 78e49486944 ("[gdb/build]
Fix gdbserver build with -fsanitize=address").

The gdbserver component builds a shared library libinproctrace.so, which uses
libiberty and therefore requires the pic variant.  The gdbserver Makefile is
setup to use this variant, if available, but it's not there.

Fix this by listing gdbserver in the toplevel configure alongside libcc1, as a
component that needs the libiberty pic variant, setting:
...
extra_host_libiberty_configure_flags=--enable-shared
...

Tested on x86_64-linux.

ChangeLog:

2022-06-27  Tom de Vries  <tdevries@suse.de>

	* configure.ac: Build libiberty pic variant for gdbserver.
	* configure: Regenerate.
This commit is contained in:
Tom de Vries 2022-06-27 12:47:26 +02:00
parent ed1c7ad8e3
commit a08bdb159b
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
configure vendored
View File

@ -6964,7 +6964,7 @@ fi
extra_host_libiberty_configure_flags= extra_host_libiberty_configure_flags=
extra_host_zlib_configure_flags= extra_host_zlib_configure_flags=
case " $configdirs " in case " $configdirs " in
*" lto-plugin "* | *" libcc1 "*) *" lto-plugin "* | *" libcc1 "* | *" gdbserver "*)
# When these are to be built as shared libraries, the same applies to # When these are to be built as shared libraries, the same applies to
# libiberty. # libiberty.
extra_host_libiberty_configure_flags=--enable-shared extra_host_libiberty_configure_flags=--enable-shared

2
configure.ac
View File

@ -2344,7 +2344,7 @@ fi
extra_host_libiberty_configure_flags= extra_host_libiberty_configure_flags=
extra_host_zlib_configure_flags= extra_host_zlib_configure_flags=
case " $configdirs " in case " $configdirs " in
*" lto-plugin "* | *" libcc1 "*) *" lto-plugin "* | *" libcc1 "* | *" gdbserver "*)
# When these are to be built as shared libraries, the same applies to # When these are to be built as shared libraries, the same applies to
# libiberty. # libiberty.
extra_host_libiberty_configure_flags=--enable-shared extra_host_libiberty_configure_flags=--enable-shared