yggdrasil/binutils-gdb
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

gdbserver/proc-service.c: bogus return value conversion

Browse Source 
Building in C++ mode shows:

   int write_inferior_memory (CORE_ADDR memaddr, const unsigned char *myaddr,
       ^
  src/gdb/gdbserver/proc-service.c:93:64: error: invalid conversion from ‘int’ to ‘ps_err_e’ [-fpermissive]
     return write_inferior_memory ((unsigned long) addr, buf, size);
								  ^

It only works today by accident, write_inferior_memory does not return
a ps_err_e.

gdb/gdbserver/ChangeLog:
2015-08-27  Pedro Alves  <palves@redhat.com>

	* proc-service.c (ps_pdwrite): Return PS_ERR/PS_OK explicily.
This commit is contained in:
Pedro Alves 2015-08-27 13:37:01 +01:00
parent 14d8814778
commit ab29043019
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gdb/gdbserver/ChangeLog
View File

@ -1,3 +1,7 @@
2015-08-27 Pedro Alves <palves@redhat.com>
* proc-service.c (ps_pdwrite): Return PS_ERR/PS_OK explicily.
2015-08-26 Simon Marchi <simon.marchi@ericsson.com>
* ax.c (gdb_parse_agent_expr): Likewise.

4
gdb/gdbserver/proc-service.c
View File

@ -90,7 +90,9 @@ ps_err_e
ps_pdwrite (gdb_ps_prochandle_t ph, psaddr_t addr,
gdb_ps_write_buf_t buf, gdb_ps_size_t size)
{
return write_inferior_memory ((unsigned long) addr, buf, size);
if (write_inferior_memory ((unsigned long) addr, buf, size) != 0)
return PS_ERR;
return PS_OK;
}
/* Get the general registers of LWP LWPID within the target process PH