yggdrasil/binutils-gdb
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Do not allocate psymtabs via psymtab_storage

Browse Source 
Currently, partial symbol tables are allocated by a method in
psymtab_storage.  However, eventually we want to subclass partial
symtabs in the symbol readers, so the calls to "new" will have to
happen there.  This patch is a first step, moving the allocation from
psymtab_storage and into allocate_psymtab.

gdb/ChangeLog
2020-01-26  Tom Tromey  <tom@tromey.com>

	* psymtab.h (class psymtab_storage) <install_psymtab>: Rename from
	allocate_psymtab.  Update documentation.
	* psymtab.c (psymtab_storage::install_psymtab): Rename from
	allocate_psymtab.  Do not use new.
	(allocate_psymtab): Use new.  Update.

Change-Id: Iba6a9bf3ee1e78062fdb9f007c3010f826f64bc8
This commit is contained in:
Tom Tromey 2019-10-22 16:51:55 -06:00
parent 6d94535fc6
commit abaa2f2340
3 changed files with 17 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
gdb/ChangeLog
View File

@ -1,3 +1,11 @@
2020-01-26 Tom Tromey <tom@tromey.com>
* psymtab.h (class psymtab_storage) <install_psymtab>: Rename from
allocate_psymtab. Update documentation.
* psymtab.c (psymtab_storage::install_psymtab): Rename from
allocate_psymtab. Do not use new.
(allocate_psymtab): Use new. Update.
2020-01-26 Tom Tromey <tom@tromey.com>
* xcoffread.c (xcoff_psymtab_to_symtab_1): Update.

16
gdb/psymtab.c
View File

@ -75,15 +75,11 @@ psymtab_storage::~psymtab_storage ()
/* See psymtab.h. */
struct partial_symtab *
psymtab_storage::allocate_psymtab ()
void
psymtab_storage::install_psymtab (partial_symtab *pst)
{
struct partial_symtab *psymtab = new struct partial_symtab;
psymtab->next = psymtabs;
psymtabs = psymtab;
return psymtab;
pst->next = psymtabs;
psymtabs = pst;
}
@ -1653,8 +1649,8 @@ init_psymbol_list (struct objfile *objfile, int total_symbols)
struct partial_symtab *
allocate_psymtab (const char *filename, struct objfile *objfile)
{
struct partial_symtab *psymtab
= objfile->partial_symtabs->allocate_psymtab ();
struct partial_symtab *psymtab = new partial_symtab;
objfile->partial_symtabs->install_psymtab (psymtab);
psymtab->filename
= ((const char *) objfile->per_bfd->filename_cache.insert

7
gdb/psymtab.h
View File

@ -83,11 +83,10 @@ public:
return OBSTACK_CALLOC (obstack (), number, struct partial_symtab *);
}
/* Allocate a new psymtab on the psymtab obstack. The new psymtab
will be linked in to the "psymtabs" list, but otherwise all other
fields will be zero. */
/* Install a psymtab on the psymtab list. This transfers ownership
of PST to this object. */
struct partial_symtab *allocate_psymtab ();
void install_psymtab (partial_symtab *pst);
typedef next_adapter<struct partial_symtab> partial_symtab_range;