yggdrasil/binutils-gdb
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

gas: make S_IS_LOCAL() and S_IS_EXTERNAL() exclusive of one another

Browse Source 
While they aren't opposites of each other, there also shouldn't be any
symbol for which both return true; both may return false. Therefore
use S_IS_EXTERNAL() in S_IS_LOCAL(), thus subsuming the sanity check
which so far both did alike.
This commit is contained in:
Jan Beulich 2023-08-18 08:57:34 +02:00
parent 899748950c
commit b41ef0baac
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
gas/symbols.c
View File

@ -2420,15 +2420,14 @@ S_IS_LOCAL (symbolS *s)
if (s->flags.local_symbol)
return 1;
flags = s->bsym->flags;
/* Sanity check. */
if ((flags & BSF_LOCAL) && (flags & BSF_GLOBAL))
abort ();
if (S_IS_EXTERNAL (s))
return 0;
if (bfd_asymbol_section (s->bsym) == reg_section)
return 1;
flags = s->bsym->flags;
if (flag_strip_local_absolute
/* Keep BSF_FILE symbols in order to allow debuggers to identify
the source file even when the object file is stripped. */