yggdrasil/binutils-gdb
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

sim/igen: Fix linker error with -fno-common

Browse Source 
GCC 10 enables -fno-common by default.  This resulted in multiple
definition linker errors since a global variable was declared and
defined in a header file:

  ld: libsim.a(idecode.o):sim/v850/idecode.h:71: multiple definition of
  `idecode_issue'; libsim.a(irun.o):sim/v850/idecode.h:71: first defined
  here

  ld: libsim.a(engine.o):sim/v850/idecode.h:71: multiple definition of
  `idecode_issue'; libsim.a(irun.o):sim/v850/idecode.h:71: first defined
  here

  ld: libsim.a(support.o):sim/v850/idecode.h:71: multiple definition of
  `idecode_issue'; libsim.a(irun.o):sim/v850/idecode.h:71: first defined
  here

  ld: libsim.a(semantics.o):sim/v850/idecode.h:71: multiple definition
  of `idecode_issue'; libsim.a(irun.o):sim/v850/idecode.h:71: first
  defined here

sim/igen

	PR sim/26194

	* lf.h (lf_get_file_type): Declare.
	* lf.c (lf_get_file_type): Define.
	* gen-idecode.c (print_idecode_issue_function_header): Use
	lf_get_file_type() to issue an extern variable declaration in
	case of header files.
This commit is contained in:
Sebastian Huber 2020-07-02 18:10:49 +02:00
parent ad8464f799
commit c4df5bbeb8
4 changed files with 20 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
sim/igen/ChangeLog
View File

@ -1,3 +1,12 @@
2020-07-03 Sebastian Huber <sebastian.huber@embedded-brains.de>
PR sim/26194
* lf.h (lf_get_file_type): Declare.
* lf.c (lf_get_file_type): Define.
* gen-idecode.c (print_idecode_issue_function_header): Use
lf_get_file_type() to issue an extern variable declaration in
case of header files.
2019-12-19 Tom Tromey <tromey@adacore.com>
PR build/24572:

2
sim/igen/gen-idecode.c
View File

@ -930,6 +930,8 @@ print_idecode_issue_function_header (lf *file,
"INLINE_IDECODE", "\n");
break;
case is_function_variable:
if (lf_get_file_type (file) == lf_is_h)
lf_printf (file, "extern ");
print_semantic_function_type (file);
lf_printf (file, " (*");
break;

7
sim/igen/lf.c
View File

@ -86,6 +86,13 @@ lf_open (char *name,
}
lf_file_type
lf_get_file_type (const lf *file)
{
return file->type;
}
void
lf_close (lf *file)
{

2
sim/igen/lf.h
View File

@ -54,6 +54,8 @@ extern lf *lf_open
lf_file_references file_references,
lf_file_type type, const char *program);
extern lf_file_type lf_get_file_type (const lf *file);
extern void lf_close (lf *file);