yggdrasil/binutils-gdb
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

gdb: fix shellcheck warnings SC2006 (use $() instead of ``) in gdbarch.sh

Browse Source 
Fix all instances of:

    In gdbarch.sh line 2195:
            printf "            `echo "$function" | sed -e 's/./ /g'`  %s %s)\n" "$returntype" "$function"
                                ^-- SC2006: Use $(...) notation instead of legacy backticked `...`.

    Did you mean:
            printf "            $(echo "$function" | sed -e 's/./ /g')  %s %s)\n" "$returntype" "$function"

See here [1] for the rationale.

[1] https://github.com/koalaman/shellcheck/wiki/SC2006

gdb/ChangeLog:

	* gdbarch.sh: Use $(...) instead of `...`.
This commit is contained in:
Simon Marchi 2020-04-29 20:35:34 -04:00
parent a6fc5ffc50
commit cb02ab2416
2 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gdb/ChangeLog
View File

@ -1,3 +1,7 @@
2020-04-29 Simon Marchi <simon.marchi@efficios.com>
* gdbarch.sh: Use $(...) instead of `...`.
2020-04-29 Simon Marchi <simon.marchi@efficios.com>
* gdbarch.sh: Use double quotes around variables.

6
gdb/gdbarch.sh
View File

@ -67,7 +67,7 @@ ${line}"
# The semantics of IFS varies between different SH's. Some
# treat ``;;' as three fields while some treat it as just two.
# Work around this by eliminating ``;;'' ....
line="`echo "${line}" | sed -e 's/;;/; ;/g' -e 's/;;/; ;/g'`"
line="$(echo "${line}" | sed -e 's/;;/; ;/g' -e 's/;;/; ;/g')"
OFS="${IFS}" ; IFS="[;]"
eval read "${read}" <<EOF
@ -2162,7 +2162,7 @@ do
printf "\n"
printf "void\n"
printf "set_gdbarch_%s (struct gdbarch *gdbarch,\n" "$function"
printf " `echo "$function" | sed -e 's/./ /g'` gdbarch_%s_ftype %s)\n" "$function" "$function"
printf " %s gdbarch_%s_ftype %s)\n" "$(echo "$function" | sed -e 's/./ /g')" "$function" "$function"
printf "{\n"
printf " gdbarch->%s = %s;\n" "$function" "$function"
printf "}\n"
@ -2192,7 +2192,7 @@ do
printf "\n"
printf "void\n"
printf "set_gdbarch_%s (struct gdbarch *gdbarch,\n" "$function"
printf " `echo "$function" | sed -e 's/./ /g'` %s %s)\n" "$returntype" "$function"
printf " %s %s %s)\n" "$(echo "$function" | sed -e 's/./ /g')" "$returntype" "$function"
printf "{\n"
printf " gdbarch->%s = %s;\n" "$function" "$function"
printf "}\n"