yggdrasil/binutils-gdb
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

wrstabs: sprintf sanitizer null destination pointer

Browse Source 
gcc-2.12 seems to be ignoring __attribute__((__returns_nonnull__))
on xmalloc.

	* wrstabs.c (stab_method_type): Use stpcpy rather than sprintf
	or strcat.
This commit is contained in:
Alan Modra 2023-08-03 08:07:54 +09:30
parent b077a53b2b
commit d191eacb7b
1 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
binutils/wrstabs.c
View File

@ -1202,17 +1202,21 @@ stab_method_type (void *p, bool domainp, int argcount,
len += strlen (args[i]);
buf = xmalloc (len);
sprintf (buf, "#%s,%s", domain, return_type);
char *out = buf;
*out++ = '#';
out = stpcpy (out, domain);
*out++ = ',';
out = stpcpy (out, return_type);
free (domain);
free (return_type);
for (i = 0; i < argcount; i++)
{
strcat (buf, ",");
strcat (buf, args[i]);
*out++ = ',';
out = stpcpy (out, args[i]);
free (args[i]);
}
strcat (buf, ";");
*out++ = ';';
*out = 0;
free (args);