yggdrasil/binutils-gdb
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

bfd: microblaze: Add 32_NONE reloc type

Browse Source 
This patch adds the R_MICROBLAZE_32_NONE relocation type.
This is a 32-bit reloc that stores the 32-bit pc relative
value in two words (with an imm instruction).

Add test case to gas test suite.

Signed-off-by: Neal Frager <neal.frager@amd.com>
Signed-off-by: Michael J. Eager <eager@eagercon.com>
This commit is contained in:
Neal Frager 2023-10-17 09:40:06 +01:00 committed by Michael J. Eager
parent 938459015c
commit d605374748
9 changed files with 51 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
bfd/bfd-in2.h
View File

@ -6463,6 +6463,11 @@ value relative to the read-write small data area anchor */
expressions of the form "Symbol Op Symbol" */
BFD_RELOC_MICROBLAZE_32_SYM_OP_SYM,
/* This is a 32 bit reloc that stores the 32 bit pc relative
value in two words (with an imm instruction).No relocation is
done here - only used for relaxing */
BFD_RELOC_MICROBLAZE_32_NONE,
/* This is a 64 bit reloc that stores the 32 bit pc relative
value in two words (with an imm instruction). No relocation is
done here - only used for relaxing */

24
bfd/elf32-microblaze.c
View File

@ -174,6 +174,21 @@ static reloc_howto_type microblaze_elf_howto_raw[] =
0x0000ffff, /* Dest Mask. */
false), /* PC relative offset? */
/* This reloc does nothing. Used for relaxation. */
HOWTO (R_MICROBLAZE_32_NONE, /* Type. */
0, /* Rightshift. */
2, /* Size (0 = byte, 1 = short, 2 = long). */
32, /* Bitsize. */
true, /* PC_relative. */
0, /* Bitpos. */
complain_overflow_bitfield, /* Complain on overflow. */
NULL, /* Special Function. */
"R_MICROBLAZE_32_NONE", /* Name. */
false, /* Partial Inplace. */
0, /* Source Mask. */
0, /* Dest Mask. */
false), /* PC relative offset? */
/* This reloc does nothing. Used for relaxation. */
HOWTO (R_MICROBLAZE_64_NONE, /* Type. */
0, /* Rightshift. */
@ -560,6 +575,9 @@ microblaze_elf_reloc_type_lookup (bfd * abfd ATTRIBUTE_UNUSED,
case BFD_RELOC_NONE:
microblaze_reloc = R_MICROBLAZE_NONE;
break;
case BFD_RELOC_MICROBLAZE_32_NONE:
microblaze_reloc = R_MICROBLAZE_32_NONE;
break;
case BFD_RELOC_MICROBLAZE_64_NONE:
microblaze_reloc = R_MICROBLAZE_64_NONE;
break;
@ -1954,6 +1972,7 @@ microblaze_elf_relax_section (bfd *abfd,
}
break;
case R_MICROBLAZE_NONE:
case R_MICROBLAZE_32_NONE:
{
/* This was a PC-relative instruction that was
completely resolved. */
@ -2009,7 +2028,8 @@ microblaze_elf_relax_section (bfd *abfd,
irelscanend = irelocs + o->reloc_count;
for (irelscan = irelocs; irelscan < irelscanend; irelscan++)
{
if (ELF32_R_TYPE (irelscan->r_info) == (int) R_MICROBLAZE_32)
if ((ELF32_R_TYPE (irelscan->r_info) == (int) R_MICROBLAZE_32) ||
(ELF32_R_TYPE (irelscan->r_info) == (int) R_MICROBLAZE_32_NONE))
{
isym = isymbuf + ELF32_R_SYM (irelscan->r_info);
@ -2068,7 +2088,7 @@ microblaze_elf_relax_section (bfd *abfd,
elf_section_data (o)->this_hdr.contents = ocontents;
}
}
irelscan->r_addend -= calc_fixup (irel->r_addend
irelscan->r_addend -= calc_fixup (irelscan->r_addend
+ isym->st_value,
0,
sec);

1
bfd/libbfd.h
View File

@ -3010,6 +3010,7 @@ static const char *const bfd_reloc_code_real_names[] = { "@@uninitialized@@",
"BFD_RELOC_MICROBLAZE_32_ROSDA",
"BFD_RELOC_MICROBLAZE_32_RWSDA",
"BFD_RELOC_MICROBLAZE_32_SYM_OP_SYM",
"BFD_RELOC_MICROBLAZE_32_NONE",
"BFD_RELOC_MICROBLAZE_64_NONE",
"BFD_RELOC_MICROBLAZE_64_GOTPC",
"BFD_RELOC_MICROBLAZE_64_GOT",

6
bfd/reloc.c
View File

@ -6694,6 +6694,12 @@ ENUM
ENUMDOC
This is a 32 bit reloc for the microblaze to handle
expressions of the form "Symbol Op Symbol"
ENUM
BFD_RELOC_MICROBLAZE_32_NONE
ENUMDOC
This is a 32 bit reloc that stores the 32 bit pc relative
value in two words (with an imm instruction). No relocation is
done here - only used for relaxing
ENUM
BFD_RELOC_MICROBLAZE_64_NONE
ENUMDOC

4
binutils/readelf.c
View File

@ -15279,6 +15279,10 @@ is_8bit_abs_reloc (Filedata * filedata, unsigned int reloc_type)
return reloc_type == 54; /* R_RISCV_SET8. */
case EM_Z80:
return reloc_type == 1; /* R_Z80_8. */
case EM_MICROBLAZE:
return (reloc_type == 33 /* R_MICROBLAZE_32_NONE. */
|| reloc_type == 0 /* R_MICROBLAZE_NONE. */
|| reloc_type == 9 /* R_MICROBLAZE_64_NONE. */);
default:
return false;
}

3
gas/config/tc-microblaze.c
View File

@ -2290,6 +2290,8 @@ md_apply_fix (fixS * fixP,
moves code around due to relaxing. */
if (fixP->fx_r_type == BFD_RELOC_64_PCREL)
fixP->fx_r_type = BFD_RELOC_MICROBLAZE_64_NONE;
else if (fixP->fx_r_type == BFD_RELOC_32)
fixP->fx_r_type = BFD_RELOC_MICROBLAZE_32_NONE;
else
fixP->fx_r_type = BFD_RELOC_NONE;
fixP->fx_addsy = section_symbol (absolute_section);
@ -2513,6 +2515,7 @@ tc_gen_reloc (asection * section ATTRIBUTE_UNUSED, fixS * fixp)
switch (fixp->fx_r_type)
{
case BFD_RELOC_NONE:
case BFD_RELOC_MICROBLAZE_32_NONE:
case BFD_RELOC_MICROBLAZE_64_NONE:
case BFD_RELOC_32:
case BFD_RELOC_MICROBLAZE_32_LO:

5
gas/testsuite/gas/microblaze/reloc_sym.d
View File

@ -30,6 +30,11 @@ Disassembly of section .text:
100000a8: 30210020 addik r1, r1, 32
100000ac: b60f0008 rtsd r15, 8
100000b0: 80000000 or r0, r0, r0
100000b4: 14422003 cmpu r2, r2, r4
100000b8: be220004 bneid r2, 4 // 100000bc <reloc_none_test>
100000bc <reloc_none_test>:
100000bc: a0630001 ori r3, r3, 1
Disassembly of section .testsection:

5
gas/testsuite/gas/microblaze/reloc_weaksym.s
View File

@ -42,7 +42,8 @@ main:
addik r1,r1,32
rtsd r15,8
nop # Unfilled delay slot
cmpu r2,r2,r4
BNEID r2,reloc_none_test
.end main
$Lfe2:
.size main,$Lfe2-main
@ -50,3 +51,5 @@ $Lfe2:
test_start = __def_start
.globl test_start_strong
test_start_strong = __def_start
reloc_none_test:
ori r3,r3,1

1
include/elf/microblaze.h
View File

@ -61,6 +61,7 @@ START_RELOC_NUMBERS (elf_microblaze_reloc_type)
RELOC_NUMBER (R_MICROBLAZE_TEXTPCREL_64, 30) /* PC-relative TEXT offset. */
RELOC_NUMBER (R_MICROBLAZE_TEXTREL_64, 31) /* TEXT Entry offset 64-bit. */
RELOC_NUMBER (R_MICROBLAZE_TEXTREL_32_LO, 32) /* TEXT Entry offset 32-bit. */
RELOC_NUMBER (R_MICROBLAZE_32_NONE, 33)
END_RELOC_NUMBERS (R_MICROBLAZE_max)
/* Global base address names. */