yggdrasil/binutils-gdb
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

gdbsupport: record and print failed selftest names

Browse Source 
Since "maint selftest" now runs quite a lot of tests (especially in an
all-targets build), I thought it would be useful to print a summary at
the end of what failed.  So, implement that.

Print the summary before the "Ran %d unit tests, %zu failed\n" line, so
that that one remains the last line, and the gdb.gdb/unittest.exp
doesn't need to be changed.

The output looks like (if I force a failure in a test):

    (gdb) maint selftest
    ...
    Running selftest value_copy.
    Running selftest xml_escape_text.
    Running selftest xml_escape_text_append.

    Failures:
      aarch64-analyze-prologue

    Ran 4134 unit tests, 1 failed
    (gdb)

Change-Id: If3aaabdd6f8078d0e6e50e8d08f3e558ab85277e
Approved-By: Tom Tromey <tom@tromey.com>
This commit is contained in:
Simon Marchi 2023-11-03 11:51:37 -04:00
parent 88bfe6ac8b
commit dbbfabb441
1 changed files with 15 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
gdbsupport/selftest.cc
View File

@ -72,8 +72,9 @@ run_verbose ()
void
run_tests (gdb::array_view<const char *const> filters, bool verbose)
{
int ran = 0, failed = 0;
int ran = 0;
run_verbose_ = verbose;
std::vector<const char *> failed;
for (const auto &test : all_selftests ())
{
@ -101,15 +102,25 @@ run_tests (gdb::array_view<const char *const> filters, bool verbose)
}
catch (const gdb_exception_error &ex)
{
++failed;
debug_printf ("Self test failed: %s\n", ex.what ());
failed.push_back (test.name.c_str ());
}
reset ();
}
debug_printf (_("Ran %d unit tests, %d failed\n"),
ran, failed);
if (!failed.empty ())
{
debug_printf ("\nFailures:\n");
for (const char *name : failed)
debug_printf (" %s\n", name);
debug_printf ("\n");
}
debug_printf (_("Ran %d unit tests, %zu failed\n"),
ran, failed.size ());
}
/* See selftest.h. */