yggdrasil/binutils-gdb
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

gdb: remove unnecessary nullptr check in free_objfile observers

Browse Source 
The free_objfile observable is never called with a nullptr objfile.

Change-Id: I1e990edeb45bc38009ccb129c623911097ab65fe
Approved-By: Tom Tromey <tom@tromey.com>
This commit is contained in:
Simon Marchi 2023-10-03 22:20:22 -04:00
parent 74daa597e7
commit e0322c6a7b
3 changed files with 2 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
gdb/breakpoint.c
View File

@ -8065,9 +8065,6 @@ disable_breakpoints_in_unloaded_shlib (program_space *pspace, so_list *solib)
static void
disable_breakpoints_in_freed_objfile (struct objfile *objfile)
{
if (objfile == NULL)
return;
/* OBJF_SHARED|OBJF_USERLOADED objfiles are dynamic modules manually
managed by the user with add-symbol-file/remove-symbol-file.
Similarly to how breakpoints in shared libraries are handled in

7
gdb/printcmd.c
View File

@ -2355,12 +2355,7 @@ disable_display_command (const char *args, int from_tty)
static void
clear_dangling_display_expressions (struct objfile *objfile)
{
struct program_space *pspace;
/* With no symbol file we cannot have a block or expression from it. */
if (objfile == NULL)
return;
pspace = objfile->pspace;
program_space *pspace = objfile->pspace;
if (objfile->separate_debug_objfile_backlink)
{
objfile = objfile->separate_debug_objfile_backlink;

3
gdb/symfile.c
View File

@ -3749,8 +3749,7 @@ static void
symfile_free_objfile (struct objfile *objfile)
{
/* Remove the target sections owned by this objfile. */
if (objfile != NULL)
current_program_space->remove_target_sections ((void *) objfile);
current_program_space->remove_target_sections (objfile);
}
/* Wrapper around the quick_symbol_functions expand_symtabs_matching "method".