yggdrasil/binutils-gdb
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

gdbscm_memory_port_write: use local variable to avoid adding casts

Browse Source 
By having a local variable of type (const gdb_byte *), we can avoid adding
two casts.

gdb/ChangeLog:

	* guile/scm-ports.c (gdbscm_memory_port_write): Declare new
	"data" local variable and use it.
This commit is contained in:
Simon Marchi 2015-10-26 08:41:37 -04:00
parent 74ef968fba
commit e0dd41e967
2 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gdb/ChangeLog
View File

@ -1,3 +1,8 @@
2015-10-26 Simon Marchi <simon.marchi@polymtl.ca>
* guile/scm-ports.c (gdbscm_memory_port_write): Declare new
"data" local variable and use it.
2015-10-26 Simon Marchi <simon.marchi@polymtl.ca>
* guile/scm-symbol.c (gdbscm_lookup_global_symbol): Add

5
gdb/guile/scm-ports.c
View File

@ -716,10 +716,11 @@ gdbscm_memory_port_flush (SCM port)
/* "write" method for memory ports. */
static void
gdbscm_memory_port_write (SCM port, const void *data, size_t size)
gdbscm_memory_port_write (SCM port, const void *void_data, size_t size)
{
scm_t_port *pt = SCM_PTAB_ENTRY (port);
ioscm_memory_port *iomem = (ioscm_memory_port *) SCM_STREAM (port);
const gdb_byte *data = (const gdb_byte *) void_data;
/* There's no way to indicate a short write, so if the request goes past
the end of the port's memory range, flag an error. */
@ -758,7 +759,7 @@ gdbscm_memory_port_write (SCM port, const void *data, size_t size)
pt->write_pos = pt->write_end;
gdbscm_memory_port_flush (port);
{
const void *ptr = ((const char *) data) + space;
const gdb_byte *ptr = data + space;
size_t remaining = size - space;
if (remaining >= pt->write_buf_size)