yggdrasil/binutils-gdb
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

sim/ppc: mark device_error function as ATTRIBUTE_NORETURN

Browse Source 
The device_error function always ends up calling the error function,
which is itself marked as ATTRIBUTE_NORETURN, so it makes sense that
device_error should also be marked ATTRIBUTE_NORETURN.

Doing this resolves a few warnings from hw_ide.c about possibly
uninitialized variables - the variables are only uninitialized after
passing through a call to device_error, which obviously means the
variables are never really used uninitialized, the simulation will
terminate with the device_error call.
This commit is contained in:
Andrew Burgess 2022-10-12 11:14:26 +01:00
parent 744875dfdc
commit e5961d2be5
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
sim/ppc/device.h
View File

@ -729,7 +729,7 @@ EXTERN_DEVICE\
(void) device_error (void) device_error
(device *me, (device *me,
const char *fmt, const char *fmt,
...) ATTRIBUTE_PRINTF_2; ...) ATTRIBUTE_NORETURN ATTRIBUTE_PRINTF_2;
INLINE_DEVICE\ INLINE_DEVICE\
(int) device_trace (int) device_trace