yggdrasil/binutils-gdb
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

gdb: change bcache::insert added parameter to bool

Browse Source 
It is currently an int, but it is used as a bool.

gdb/ChangeLog:

	* bcache.h (struct bcache) <insert>: Change type of `added` to
	pointer to bool.
	* bcache.c (bcache::insert): Likewise.
	* gdbtypes.c (check_types_worklist): Adjust.
	* psymtab.c (add_psymbol_to_bcache): Adjust.

Change-Id: I06b1041636c656782a89cb6106c9ae2593f61616
This commit is contained in:
Simon Marchi 2020-09-01 12:54:38 -04:00
parent 4c8584be76
commit ef5e5b0b65
5 changed files with 20 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
gdb/ChangeLog
View File

@ -1,3 +1,11 @@
2020-09-01 Simon Marchi <simon.marchi@polymtl.ca>
* bcache.h (struct bcache) <insert>: Change type of `added` to
pointer to bool.
* bcache.c (bcache::insert): Likewise.
* gdbtypes.c (check_types_worklist): Adjust.
* psymtab.c (add_psymbol_to_bcache): Adjust.
2020-08-31 Kevin Buettner <kevinb@redhat.com>
* corelow.c (unordered_set): Include.

10
gdb/bcache.c
View File

@ -140,15 +140,15 @@ bcache::expand_hash_table ()
returning an old entry. */
const void *
bcache::insert (const void *addr, int length, int *added)
bcache::insert (const void *addr, int length, bool *added)
{
unsigned long full_hash;
unsigned short half_hash;
int hash_index;
struct bstring *s;
if (added)
*added = 0;
if (added != nullptr)
*added = false;
/* Lazily initialize the obstack. This can save quite a bit of
memory in some cases. */
@ -203,8 +203,8 @@ bcache::insert (const void *addr, int length, int *added)
m_unique_size += length;
m_structure_size += BSTRING_SIZE (length);
if (added)
*added = 1;
if (added != nullptr)
*added = true;
return &newobj->d.data;
}

4
gdb/bcache.h
View File

@ -161,12 +161,12 @@ struct bcache
/* Find a copy of the LENGTH bytes at ADDR in BCACHE. If BCACHE has
never seen those bytes before, add a copy of them to BCACHE. In
either case, return a pointer to BCACHE's copy of that string.
Since the cached value is ment to be read-only, return a const
Since the cached value is meant to be read-only, return a const
buffer. If ADDED is not NULL, set *ADDED to true if the bytes
were newly added to the cache, or to false if the bytes were
found in the cache. */
const void *insert (const void *addr, int length, int *added = nullptr);
const void *insert (const void *addr, int length, bool *added = nullptr);
/* Print statistics on this bcache's memory usage and efficacity at
eliminating duplication. TYPE should be a string describing the

2
gdb/gdbtypes.c
View File

@ -4088,7 +4088,7 @@ check_types_worklist (std::vector<type_equality_entry> *worklist,
{
while (!worklist->empty ())
{
int added;
bool added;
struct type_equality_entry entry = std::move (worklist->back ());
worklist->pop_back ();

11
gdb/psymtab.c
View File

@ -1590,9 +1590,8 @@ psymbol_compare (const void *addr1, const void *addr2, int length)
different domain (or address) is possible and correct. */
static struct partial_symbol *
add_psymbol_to_bcache (const partial_symbol &psymbol,
struct objfile *objfile,
int *added)
add_psymbol_to_bcache (const partial_symbol &psymbol, struct objfile *objfile,
bool *added)
{
/* Stash the partial symbol away in the cache. */
return ((struct partial_symbol *)
@ -1618,12 +1617,10 @@ add_psymbol_to_list (const partial_symbol &psymbol,
psymbol_placement where,
struct objfile *objfile)
{
struct partial_symbol *psym;
int added;
bool added;
/* Stash the partial symbol away in the cache. */
psym = add_psymbol_to_bcache (psymbol, objfile, &added);
partial_symbol *psym = add_psymbol_to_bcache (psymbol, objfile, &added);
/* Do not duplicate global partial symbols. */
if (where == psymbol_placement::GLOBAL && !added)