yggdrasil/binutils-gdb
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Disable the undefined behavior sanitizer by default

Browse Source 
There have been a few undefined behavior failures reported, and Pedro
suggested that the sanitizer be disabled by default.  This patch
implements this.

gdb/ChangeLog
2018-10-09  Tom Tromey  <tom@tromey.com>

	* configure: Rebuild.
	* sanitize.m4 (AM_GDB_UBSAN): Default to no.
	* NEWS: Update --enable-ubsan documentation.

gdb/doc/ChangeLog
2018-10-09  Tom Tromey  <tom@tromey.com>

	* gdb.texinfo (Configure Options): Update --enable-ubsan
	documentation.
This commit is contained in:
Tom Tromey 2018-10-09 11:51:33 -06:00
parent 104fefeebb
commit eff98030f9
6 changed files with 25 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gdb/ChangeLog
View File

@ -1,3 +1,9 @@
2018-10-09 Tom Tromey <tom@tromey.com>
* configure: Rebuild.
* sanitize.m4 (AM_GDB_UBSAN): Default to no.
* NEWS: Update --enable-ubsan documentation.
2018-10-09 Gary Benson <gbenson@redhat.com>
* dwarf2read.c (create_dwp_hash_table): Fix buffer overrun

10
gdb/NEWS
View File

@ -122,11 +122,11 @@ FreeBSD/riscv riscv*-*-freebsd*
--enable-ubsan
Enable or disable the undefined behavior sanitizer. Release
versions of GDB disable this by default if it is available, but
development versions enable it. Enabling this can cause a
performance penalty. The undefined behavior sanitizer was first
introduced in GCC 4.9.
Enable or disable the undefined behavior sanitizer. This is
disabled by default, but passing --enable-ubsan=yes or
--enable-ubsan=auto to configure will enable it. Enabling this can
cause a performance penalty. The undefined behavior sanitizer was
first introduced in GCC 4.9.
*** Changes in GDB 8.2

2
gdb/configure vendored
View File

@ -15614,7 +15614,7 @@ ac_compiler_gnu=$ac_cv_c_compiler_gnu
if test "${enable_ubsan+set}" = set; then :
enableval=$enable_ubsan;
else
enable_ubsan=auto
enable_ubsan=no
fi
if test "x$enable_ubsan" = xauto; then

5
gdb/doc/ChangeLog
View File

@ -1,3 +1,8 @@
2018-10-09 Tom Tromey <tom@tromey.com>
* gdb.texinfo (Configure Options): Update --enable-ubsan
documentation.
2018-10-08 John Baldwin <jhb@FreeBSD.org>
* gdb.texinfo (Contributors): Add SRI International and University

13
gdb/doc/gdb.texinfo
View File

@ -35771,12 +35771,13 @@ to the compiler, which will fail the compilation if the compiler
outputs any warning messages.
@item --enable-ubsan
Enable the GCC undefined behavior sanitizer. By default this is
disabled in @value{GDBN} releases, but enabled, when available, when
building from git. The undefined behavior sanitizer checks for
C@t{++} undefined behavior. It has a performance cost, so if you are
looking at @value{GDBN}'s performance, you should disable it. The
undefined behavior sanitizer was first introduced in GCC 4.9.
Enable the GCC undefined behavior sanitizer. This is disabled by
default, but passing @code{--enable-ubsan=yes} or
@code{--enable-ubsan=auto} to @code{configure} will enable it. The
undefined behavior sanitizer checks for C@t{++} undefined behavior.
It has a performance cost, so if you are looking at @value{GDBN}'s
performance, you should disable it. The undefined behavior sanitizer
was first introduced in GCC 4.9.
@end table
@node System-wide configuration

2
gdb/sanitize.m4
View File

@ -20,7 +20,7 @@ AC_DEFUN([AM_GDB_UBSAN],[
AC_ARG_ENABLE(ubsan,
AS_HELP_STRING([--enable-ubsan],
[enable undefined behavior sanitizer (auto/yes/no)]),
[],enable_ubsan=auto)
[],enable_ubsan=no)
if test "x$enable_ubsan" = xauto; then
if $development; then
enable_ubsan=yes