yggdrasil/binutils-gdb
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ld: Add -z separate-code tests to frame.exp

Browse Source 
On x86, "-z separate-code" leads to assertion fail at bfd/elf.c:5917.
Alsp skip tests if -shared isn't supported.

	PR ld/22845
	* testsuite/ld-elf/frame.exp: Skip if -shared isn't supported.
	Add tests for "-z noseparate-code" and "-z separate-code".
	Remove unsupported -shared check.
This commit is contained in:
H.J. Lu 2018-02-19 05:07:33 -08:00
parent e207bc53a4
commit f61f94ec1b
2 changed files with 26 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
ld/ChangeLog
View File

@ -1,3 +1,10 @@
2018-02-19 H.J. Lu <hongjiu.lu@intel.com>
PR ld/22845
* testsuite/ld-elf/frame.exp: Skip if -shared isn't supported.
Add tests for "-z noseparate-code" and "-z separate-code".
Remove unsupported -shared check.
2018-02-17 H.J. Lu <hongjiu.lu@intel.com> 2018-02-17 H.J. Lu <hongjiu.lu@intel.com>
PR ld/22845 PR ld/22845

34
ld/testsuite/ld-elf/frame.exp
View File

@ -29,7 +29,7 @@ if ![is_elf_format] {
} }
# No shared lib support on this target. # No shared lib support on this target.
if { [istarget "mcore-*-*"] } { if ![istarget shared] {
return return
} }
@ -64,14 +64,16 @@ if { ![ld_assemble_flags $as $as_opt $srcdir/$subdir/tbss.s tmpdir/tbss.o ]
return return
} }
if { [ld_link $ld tmpdir/frame.so "--shared tmpdir/frame.o tmpdir/tbss.o"] } { if { [ld_link $ld tmpdir/frame.so "-z noseparate-code --shared tmpdir/frame.o tmpdir/tbss.o"] } {
pass "$test1" pass "$test1 -z noseparate-code"
} else { } else {
if [string match "*shared not supported*" $link_output] { fail "$test1 -z noseparate-code"
unsupported "-shared is not supported by this target" }
} else {
fail "$test1" if { [ld_link $ld tmpdir/frame.so "-z separate-code --shared tmpdir/frame.o tmpdir/tbss.o"] } {
} pass "$test1 -z separate-code"
} else {
fail "$test1 -z separate-code"
} }
if ![ld_assemble_flags $as $as_opt $srcdir/$subdir/table.s tmpdir/table.o ] { if ![ld_assemble_flags $as $as_opt $srcdir/$subdir/table.s tmpdir/table.o ] {
@ -79,12 +81,14 @@ if ![ld_assemble_flags $as $as_opt $srcdir/$subdir/table.s tmpdir/table.o ] {
return return
} }
if { [ld_link $ld tmpdir/table.so "--shared tmpdir/table.o tmpdir/tbss.o"] } { if { [ld_link $ld tmpdir/table.so "-z noseparate-code --shared tmpdir/table.o tmpdir/tbss.o"] } {
pass "$test2" pass "$test2 -z noseparate-code"
} else { } else {
if [string match "*shared not supported*" $link_output] { fail "$test2 -z noseparate-code"
unsupported "-shared is not supported by this target" }
} else {
fail "$test2" if { [ld_link $ld tmpdir/table.so "-z separate-code --shared tmpdir/table.o tmpdir/tbss.o"] } {
} pass "$test2 -z separate-code"
} else {
fail "$test2 -z separate-code"
} }