yggdrasil/binutils-gdb
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

PR22537, Segmentation fault with static PIE

Browse Source 
The only stub type that makes sense for undefined symbols, or those
defined in shared libraries, is a plt call stub.  This patch arranges
to have "destination" set to -1 on such symbols, making for an easy
test in hppa_type_of_stub.

	PR 22537
	* elf32-hppa.c (elf32_hppa_size_stubs): Init "destination" to -1.
	(hppa_type_of_stub): Don't return a long branch stub for
	symbols other than those defined statically.
This commit is contained in:
Alan Modra 2018-04-19 14:13:41 +09:30
parent 8e415ce8fe
commit f6a8b8c7ac
2 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
bfd/ChangeLog
View File

@ -1,3 +1,10 @@
2018-04-19 Alan Modra <amodra@gmail.com>
PR 22537
* elf32-hppa.c (elf32_hppa_size_stubs): Init "destination" to -1.
(hppa_type_of_stub): Don't return a long branch stub for
symbols other than those defined statically.
2018-04-19 Alan Modra <amodra@gmail.com>
* Makefile.am: Revert 2018-04-18 coff-mips changes.

5
bfd/elf32-hppa.c
View File

@ -612,6 +612,9 @@ hppa_type_of_stub (asection *input_sec,
return hppa_stub_import;
}
if (destination == (bfd_vma) -1)
return hppa_stub_none;
/* Determine where the call point is. */
location = (input_sec->output_offset
+ input_sec->output_section->vma
@ -2843,7 +2846,7 @@ elf32_hppa_size_stubs
section. */
sym_sec = NULL;
sym_value = 0;
destination = 0;
destination = -1;
hh = NULL;
if (r_indx < symtab_hdr->sh_info)
{