yggdrasil/binutils-gdb
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

guile: Type-check the argument to 'history-append!'.

Browse Source 
gdb/
2014-06-05  Ludovic Courtès  <ludo@gnu.org>

	* guile/scm-value.c (gdbscm_history_append_x): Use
	'vlscm_get_value_smob_arg_unsafe' instead of
	'vlscm_scm_to_value'.

gdb/testsuite/
2014-06-05  Ludovic Courtès  <ludo@gnu.org>

	* gdb.guile/scm-value.exp (test_value_in_inferior): Add test
	"history-append! type error".
This commit is contained in:
Ludovic Courtès 2014-06-06 00:02:33 +02:00
parent 6ef284bd18
commit fb9347707f
4 changed files with 18 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gdb/ChangeLog
View File

@ -1,3 +1,9 @@
2014-06-05 Ludovic Courtès <ludo@gnu.org>
* guile/scm-value.c (gdbscm_history_append_x): Use
'vlscm_get_value_smob_arg_unsafe' instead of
'vlscm_scm_to_value'.
2014-06-05 Simon Marchi <simon.marchi@ericsson.com>
PR mi/15806

4
gdb/guile/scm-value.c
View File

@ -1295,9 +1295,11 @@ gdbscm_history_append_x (SCM value)
{
int res_index = -1;
struct value *v;
value_smob *v_smob;
volatile struct gdb_exception except;
v = vlscm_scm_to_value (value);
v_smob = vlscm_get_value_smob_arg_unsafe (value, SCM_ARG1, FUNC_NAME);
v = v_smob->value;
TRY_CATCH (except, RETURN_MASK_ALL)
{

5
gdb/testsuite/ChangeLog
View File

@ -1,3 +1,8 @@
2014-06-05 Ludovic Courtès <ludo@gnu.org>
* gdb.guile/scm-value.exp (test_value_in_inferior): Add test
"history-append! type error".
2014-06-05 Simon Marchi <simon.marchi@ericsson.com>
* gdb.mi/mi-breakpoint-changed.exp (test_insert_delete_modify): Fix

4
gdb/testsuite/gdb.guile/scm-value.exp
View File

@ -71,6 +71,10 @@ proc test_value_in_inferior {} {
gdb_test_no_output "guile (gc)"
gdb_test "p \$\$" "= 42"
# Make sure 'history-append!' rejects non-value objects.
gdb_test "gu (history-append! 123)" \
"ERROR:.* Wrong type argument.*" "history-append! type error"
# Test dereferencing the argv pointer.
# Just get inferior variable argv the value history, available to guile.