8cb6e17571
Looking at the ARM disassembler output, every comment seems to start
with a ';' character, so I assumed this was the correct character to
start an assembler comment.
I then spotted a couple of places where there was no ';', but instead,
just a '@' character. I thought that this was a case of a missing
';', and proposed a patch to add the missing ';' characters.
Turns out I was wrong, '@' is actually the ARM assembler comment
character, while ';' is the statement separator. Thus this:
nop ;@ comment
is two statements, the first is the 'nop' instruction, while the
second contains no instructions, just the '@ comment' comment text.
This:
nop @ comment
is a single 'nop' instruction followed by a comment. And finally,
this:
nop ; comment
is two statements, the first contains the 'nop' instruction, while the
second contains the instruction 'comment', which obviously isn't
actually an instruction at all.
Why this matters is that, in the next commit, I would like to add
libopcodes syntax styling support for ARM.
The question then is how should the disassembler style the three cases
above?
As '@' is the actual comment start character then clearly the '@' and
anything after it can be styled as a comment. But what about ';' in
the second example? Style as text? Style as a comment?
And the third example is even harder, what about the 'comment' text?
Style as an instruction mnemonic? Style as text? Style as a comment?
I think the only sensible answer is to move the disassembler to use
'@' consistently as its comment character, and remove all the uses of
';'.
Then, in the next commit, it's obvious what to do.
There's obviously a *lot* of tests that get updated by this commit,
the only actual code changes are in opcodes/arm-dis.c.
19 lines
578 B
Makefile
19 lines
578 B
Makefile
|
|
.*: file format elf32-.*arm.*
|
|
architecture: arm.*, flags 0x00000112:
|
|
EXEC_P, HAS_SYMS, D_PAGED
|
|
start address 0x00008[0-9a-f]+
|
|
|
|
Disassembly of section .text:
|
|
|
|
00008[0-9a-f]+ <foo>:
|
|
8[0-9a-f]+: e1a00000 nop @ \(mov r0, r0\)
|
|
8[0-9a-f]+: e1a00000 nop @ \(mov r0, r0\)
|
|
8[0-9a-f]+: e1a0f00e mov pc, lr
|
|
8[0-9a-f]+: 000080bc .word 0x000080bc
|
|
8[0-9a-f]+: 000080b4 .word 0x000080b4
|
|
8[0-9a-f]+: 000080ac .word 0x000080ac
|
|
8[0-9a-f]+: 00000004 .word 0x00000004
|
|
8[0-9a-f]+: 000080c4 .word 0x000080c4
|
|
8[0-9a-f]+: 00000014 .word 0x00000014
|