Mike Frysinger
b2ea48df92
sim: cgen: rework DI macros to avoid signed left shifts
...
The cgen code uses DI as int64_t and UDI as uint64_t. The DI macros
are used to construct 64-bit values from 32-bit values (for the low
and high parts). The MAKEDI macro casts the high 32-bit value to a
signed 32-bit value before shifting. If this created a negative
value, this would be undefined behavior according to the C standard.
All we care about is shifting the 32-bits as they are to the high
32-bits, not caring about sign extension (since there's nothing left
to shift into), and the low 32-bits being empty. This is what we
get from shifting an unsigned value, so cast it to unsigned 32-bit
to avoid undefined behavior.
While we're here, change the SETLODI macro to truncate the lower
value to 32-bits before we set it. If it was passing in a 64-bit
value, those high bits would get included too, and that's not what
we want.
Similarly, tweak the SETHIDI macro to cast the value to an unsigned
64-bit instead of a signed 64-bit. If the value was only 32-bits,
the behavior would be the same. If it happened to be signed 64-bit,
it would trigger the undefined behavior too.
2024-01-08 20:01:05 -05:00
..
2023-01-16 04:35:48 -05:00
2022-01-06 01:17:39 -05:00
2023-01-01 17:01:16 +04:00
2023-01-01 17:01:16 +04:00
2023-01-01 17:01:16 +04:00
2021-05-16 22:38:41 -04:00
2023-01-01 17:01:16 +04:00
2023-12-24 05:09:28 -05:00
2023-01-01 17:01:16 +04:00
2023-01-01 17:01:16 +04:00
2023-12-19 05:51:09 -05:00
2023-12-19 05:51:09 -05:00
2023-01-18 20:47:55 -05:00
2023-01-01 17:01:16 +04:00
2023-01-01 17:01:16 +04:00
2023-01-01 17:01:16 +04:00
2024-01-08 20:01:05 -05:00
2023-01-01 17:01:16 +04:00
2023-08-26 13:09:38 -06:00
2021-08-17 20:27:36 -04:00
2023-01-01 17:01:16 +04:00
2023-12-21 01:59:22 -05:00
2023-12-21 01:59:22 -05:00
2023-01-01 17:01:16 +04:00
2023-01-01 17:01:16 +04:00
2023-01-01 17:01:16 +04:00
2023-01-16 04:35:48 -05:00
2023-01-16 04:35:48 -05:00
2023-01-01 17:01:16 +04:00
2022-03-28 23:10:34 -04:00
2023-12-21 20:16:26 -05:00
2023-12-26 22:53:31 -05:00
2023-01-01 17:01:16 +04:00
2023-01-01 17:01:16 +04:00
2023-12-07 22:31:21 -07:00
2023-01-01 17:01:16 +04:00
2023-01-01 17:01:16 +04:00
2023-01-01 17:01:16 +04:00
2023-01-10 01:15:29 -05:00
2023-01-01 17:01:16 +04:00
2023-01-01 17:01:16 +04:00
2023-01-01 17:01:16 +04:00
2023-01-01 17:01:16 +04:00
2023-01-01 17:01:16 +04:00
2023-01-01 17:01:16 +04:00
2024-01-01 10:44:13 -05:00
2023-01-01 17:01:16 +04:00
2024-01-01 10:44:13 -05:00
2023-01-01 17:01:16 +04:00
2024-01-01 10:44:13 -05:00
2023-01-01 17:01:16 +04:00
2023-12-21 20:16:26 -05:00
2023-12-21 20:16:26 -05:00
2023-01-16 04:35:48 -05:00
2023-01-01 17:01:16 +04:00
2023-01-01 17:01:16 +04:00
2023-01-01 17:01:16 +04:00
2023-01-01 17:01:16 +04:00
2023-01-01 17:01:16 +04:00
2023-01-01 17:01:16 +04:00
2023-01-01 17:01:16 +04:00
2023-01-01 17:01:16 +04:00
2023-01-01 17:01:16 +04:00
2024-01-01 10:44:13 -05:00
2023-01-01 17:01:16 +04:00
2023-01-01 17:01:16 +04:00
2023-01-01 17:01:16 +04:00
2023-01-01 17:01:16 +04:00
2023-01-01 17:01:16 +04:00
2023-01-01 17:01:16 +04:00
2024-01-01 10:44:13 -05:00
2023-12-21 01:59:22 -05:00
2023-01-01 17:01:16 +04:00
2023-01-01 17:01:16 +04:00
2023-01-01 17:01:16 +04:00
2024-01-03 02:15:54 -05:00
2023-01-01 17:01:16 +04:00
2023-12-21 01:23:00 -05:00
2023-01-01 17:01:16 +04:00
2023-01-01 17:01:16 +04:00
2023-12-22 23:29:19 -05:00
2023-01-01 17:01:16 +04:00
2023-01-01 17:01:16 +04:00
2023-01-01 17:01:16 +04:00
2023-01-01 17:01:16 +04:00
2023-01-01 17:01:16 +04:00
2023-01-18 20:47:55 -05:00
2023-01-01 17:01:16 +04:00
2023-01-01 17:01:16 +04:00
2023-01-16 04:35:48 -05:00
2023-01-01 17:01:16 +04:00
2023-01-01 17:01:16 +04:00
2023-12-21 01:59:22 -05:00
2023-01-01 17:01:16 +04:00
2023-01-01 17:01:16 +04:00
2023-01-01 17:01:16 +04:00
2023-12-19 05:51:09 -05:00
2023-01-18 20:47:55 -05:00
2023-01-01 17:01:16 +04:00
2023-01-01 17:01:16 +04:00
2023-01-01 17:01:16 +04:00
2023-12-22 23:29:19 -05:00
2023-01-01 17:01:16 +04:00
2023-01-18 20:47:55 -05:00
2023-01-18 20:47:55 -05:00
2023-01-01 17:01:16 +04:00
2023-01-01 17:01:16 +04:00
2023-01-01 17:01:16 +04:00
2023-01-01 17:01:16 +04:00
2023-01-18 19:26:58 -05:00
2023-01-01 17:01:16 +04:00
2023-01-01 17:01:16 +04:00
2023-01-01 17:01:16 +04:00
2023-01-01 17:01:16 +04:00
2023-01-01 17:01:16 +04:00
2023-01-01 17:01:16 +04:00
2023-01-01 17:01:16 +04:00
2023-01-01 17:01:16 +04:00
2023-01-01 17:01:16 +04:00
2023-12-19 05:51:09 -05:00
2023-01-01 17:01:16 +04:00
2023-12-19 05:51:09 -05:00
2023-12-26 22:53:31 -05:00
2023-01-01 17:01:16 +04:00
2023-01-01 17:01:16 +04:00
2023-01-01 17:01:16 +04:00
2023-01-01 17:01:16 +04:00
2023-01-01 17:01:16 +04:00