re PR libgcj/3426 (java.io.InputStreamReader, infinite loop)

Fix for PR libgcj/3426:
	* gnu/gcj/convert/natIconv.cc: Include CharConversionException.h,
	errno.h.
	(read): Throw exception if character conversion fails.
	* java/io/BufferedInputStream.java (refill): Now package-private.
	* java/io/InputStreamReader.java (ready): Simplified.
	(refill): New method.
	(read): Use it.

Co-Authored-By: David Brownell <david-b@pacbell.net>

From-SVN: r43975
This commit is contained in:
Tom Tromey
2001-07-13 05:41:28 +00:00
committed by Tom Tromey
parent c813baa415
commit a9a399fe24
4 changed files with 84 additions and 65 deletions
+12 -2
View File
@@ -1,6 +1,6 @@
// Input_iconv.java -- Java side of iconv() reader.
/* Copyright (C) 2000 Free Software Foundation
/* Copyright (C) 2000, 2001 Free Software Foundation
This file is part of libgcj.
@@ -17,8 +17,11 @@ details. */
#include <gnu/gcj/convert/Input_iconv.h>
#include <gnu/gcj/convert/Output_iconv.h>
#include <java/io/CharConversionException.h>
#include <java/io/UnsupportedEncodingException.h>
#include <errno.h>
#ifdef HAVE_ICONV
#include <iconv.h>
@@ -84,7 +87,14 @@ gnu::gcj::convert::Input_iconv::read (jcharArray outbuffer,
size_t r = iconv_adapter (iconv, (iconv_t) handle,
&inbuf, &inavail,
&outbuf, &outavail);
// FIXME: what if R==-1?
if (r == (size_t) -1)
{
// Incomplete character.
if (errno == EINVAL)
return 0;
throw new java::io::CharConversionException ();
}
if (iconv_byte_swap)
{