From 41b89814e332aa20e8916579f95762de784d6b4b Mon Sep 17 00:00:00 2001 From: Joseph Richey Date: Thu, 23 Feb 2023 11:56:11 -0800 Subject: [PATCH] Allow Edge tests to fail (#339) Window's `msedgedriver` seems to be unreliable, as port binding will occasionally fail. Instead of wasting time trying to debug this, just let the tests fail. We take a similar approch for Safari's webdriver, we will allow the tests to fail, but will hopefully see when they start succeeding (when Safari fixes the COOP bug). Signed-off-by: Joe Richey --- .github/workflows/tests.yml | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index dd2b128..f894faa 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -195,9 +195,8 @@ jobs: host: x86_64-unknown-linux-musl - os: windows-2022 host: x86_64-pc-windows-msvc - # Re-enable when Safari tests start working - # - os: macos-12 - # host: x86_64-apple-darwin + - os: macos-12 + host: x86_64-apple-darwin runs-on: ${{ matrix.os }} steps: - uses: actions/checkout@v3 @@ -220,11 +219,14 @@ jobs: run: wasm-pack test --headless --chrome --features=js,test-in-browser - name: Test (Edge) if: runner.os == 'Windows' + # Edge has flaky failures: "driver failed to bind port during startup" + continue-on-error: true run: wasm-pack test --headless --chrome --chromedriver $Env:EDGEWEBDRIVER\msedgedriver.exe --features=js,test-in-browser - # Safari tests are broken: https://github.com/rustwasm/wasm-bindgen/issues/3004 - # - name: Test (Safari) - # if: runner.os == 'macOS' - # run: wasm-pack test --headless --safari --features=js,test-in-browser + - name: Test (Safari) + if: runner.os == 'macOS' + # Safari tests are broken: https://github.com/rustwasm/wasm-bindgen/issues/3004 + continue-on-error: true + run: wasm-pack test --headless --safari --features=js,test-in-browser - name: Test (custom getrandom) run: wasm-pack test --node --features=custom