yggdrasil/getrandom
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Update Module::require internal comments

Browse Source 
Signed-off-by: Joe Richey <joerichey@google.com>
This commit is contained in:
Joe Richey 2022-10-06 14:52:39 -07:00
parent e0c93b10d5
commit 9962c706c9
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/js.rs
View File

@ -122,9 +122,12 @@ extern "C" {
#[wasm_bindgen(method, js_name = randomFillSync, catch)] #[wasm_bindgen(method, js_name = randomFillSync, catch)]
fn random_fill_sync(this: &NodeCrypto, buf: &mut [u8]) -> Result<(), JsValue>; fn random_fill_sync(this: &NodeCrypto, buf: &mut [u8]) -> Result<(), JsValue>;
// We use a "module" object here instead of just annotating require() with // Ideally, we would just use `fn require(s: &str)` here. However, doing
// js_name = "module.require", so that Webpack doesn't give a warning. See: // this causes a Webpack warning. So we instead return the function itself
// and manually invoke it using call1. This also lets us to check that the
// function actually exists, allowing for better error messages. See:
// https://github.com/rust-random/getrandom/issues/224 // https://github.com/rust-random/getrandom/issues/224
// https://github.com/rust-random/getrandom/issues/256
type Module; type Module;
#[wasm_bindgen(getter, static_method_of = Module, js_class = module, js_name = require, catch)] #[wasm_bindgen(getter, static_method_of = Module, js_class = module, js_name = require, catch)]
fn require_fn() -> Result<JsValue, JsValue>; fn require_fn() -> Result<JsValue, JsValue>;