69297cf639
Main motivation: including `llvm/CodeGen/CommandFlags.h` in `CommonLinkerContext.h` means that the declaration of `llvm::Reloc` is visible in any file that includes `CommonLinkerContext.h`. Since our cpp files have both `using namespace llvm` and `using namespace lld::macho`, this results in conflicts with `lld::macho::Reloc`. I suppose we could put `llvm::Reloc` into a nested namespace, but in general, I think we should avoid transitively including too many header files in a very widely used header like `CommonLinkerContext.h`. RegisterCodeGenFlags' ctor initializes a bunch of function-`static` structures and does nothing else, so it should be fine to "initialize" it as a temporary stack variable rather than as a file static. Reviewed By: aganea Differential Revision: https://reviews.llvm.org/D119913
52 lines
1.5 KiB
C++
52 lines
1.5 KiB
C++
//===- CommonLinkerContext.cpp --------------------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "lld/Common/CommonLinkerContext.h"
|
|
#include "lld/Common/ErrorHandler.h"
|
|
#include "lld/Common/Memory.h"
|
|
|
|
#include "llvm/CodeGen/CommandFlags.h"
|
|
|
|
using namespace llvm;
|
|
using namespace lld;
|
|
|
|
// Reference to the current LLD instance. This is a temporary situation, until
|
|
// we pass this context everywhere by reference, or we make it a thread_local,
|
|
// as in https://reviews.llvm.org/D108850?id=370678 where each thread can be
|
|
// associated with a LLD instance. Only then will LLD be free of global
|
|
// state.
|
|
static CommonLinkerContext *lctx;
|
|
|
|
CommonLinkerContext::CommonLinkerContext() {
|
|
lctx = this;
|
|
// Fire off the static initializations in CGF's constructor.
|
|
codegen::RegisterCodeGenFlags CGF;
|
|
}
|
|
|
|
CommonLinkerContext::~CommonLinkerContext() {
|
|
assert(lctx);
|
|
// Explicitly call the destructors since we created the objects with placement
|
|
// new in SpecificAlloc::create().
|
|
for (auto &it : instances)
|
|
it.second->~SpecificAllocBase();
|
|
lctx = nullptr;
|
|
}
|
|
|
|
CommonLinkerContext &lld::commonContext() {
|
|
assert(lctx);
|
|
return *lctx;
|
|
}
|
|
|
|
bool lld::hasContext() { return lctx != nullptr; }
|
|
|
|
void CommonLinkerContext::destroy() {
|
|
if (lctx == nullptr)
|
|
return;
|
|
delete lctx;
|
|
}
|