From 4a8752274c156bf47b5cfabc14a7d31c9c8bf96f Mon Sep 17 00:00:00 2001
From: Josh Stone <cuviper@gmail.com>
Date: Tue, 15 Dec 2015 22:07:34 -0800
Subject: [PATCH] bigint: slightly improve multiply/divide performance

Using `vec![0; len]` initialization is a little faster.

Before:
     test multiply_0        ... bench:         354 ns/iter (+/- 6)
     test multiply_1        ... bench:      33,966 ns/iter (+/- 1,508)
     test multiply_2        ... bench:   3,663,686 ns/iter (+/- 60,880)
     test divide_0          ... bench:         891 ns/iter (+/- 51)
     test divide_1          ... bench:      17,316 ns/iter (+/- 387)
     test divide_2          ... bench:   1,290,378 ns/iter (+/- 73,016)

After:
     test multiply_0        ... bench:         351 ns/iter (+/- 39)
     test multiply_1        ... bench:      30,827 ns/iter (+/- 680)
     test multiply_2        ... bench:   3,692,968 ns/iter (+/- 91,146)
     test divide_0          ... bench:         902 ns/iter (+/- 14)
     test divide_1          ... bench:      16,981 ns/iter (+/- 102)
     test divide_2          ... bench:   1,146,367 ns/iter (+/- 60,152)
---
 src/bigint.rs | 15 ++++-----------
 1 file changed, 4 insertions(+), 11 deletions(-)

diff --git a/src/bigint.rs b/src/bigint.rs
index 32c184f..8b553c4 100644
--- a/src/bigint.rs
+++ b/src/bigint.rs
@@ -849,8 +849,7 @@ fn mac3(acc: &mut [BigDigit], b: &[BigDigit], c: &[BigDigit]) {
         /* We reuse the same BigUint for all the intermediate multiplies: */
 
         let len = y.len() + 1;
-        let mut p: BigUint = BigUint { data: Vec::with_capacity(len) };
-        p.data.extend(repeat(0).take(len));
+        let mut p = BigUint { data: vec![0; len] };
 
         // p2 = x1 * y1
         mac3(&mut p.data[..], x1, y1);
@@ -897,11 +896,7 @@ fn mac3(acc: &mut [BigDigit], b: &[BigDigit], c: &[BigDigit]) {
 
 fn mul3(x: &[BigDigit], y: &[BigDigit]) -> BigUint {
     let len = x.len() + y.len() + 1;
-    let mut prod: BigUint = BigUint { data: Vec::with_capacity(len) };
-
-    // resize isn't stable yet:
-    //prod.data.resize(len, 0);
-    prod.data.extend(repeat(0).take(len));
+    let mut prod = BigUint { data: vec![0; len] };
 
     mac3(&mut prod.data[..], x, y);
     prod.normalize()
@@ -1058,16 +1053,14 @@ impl Integer for BigUint {
 
         let bn = *b.data.last().unwrap();
         let q_len = a.data.len() - b.data.len() + 1;
-        let mut q: BigUint = BigUint { data: Vec::with_capacity(q_len) };
-
-        q.data.extend(repeat(0).take(q_len));
+        let mut q = BigUint { data: vec![0; q_len] };
 
         /*
          * We reuse the same temporary to avoid hitting the allocator in our inner loop - this is
          * sized to hold a0 (in the common case; if a particular digit of the quotient is zero a0
          * can be bigger).
          */
-        let mut tmp: BigUint = BigUint { data: Vec::with_capacity(2) };
+        let mut tmp = BigUint { data: Vec::with_capacity(2) };
 
         for j in (0..q_len).rev() {
             /*