yggdrasil/ring
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

RSA: Eliminate a redundant clone.

Browse Source 
Commit be27e8e25946b2e975258cfb1ea21f6cc4731d8c made this clone
unnecessary.
This commit is contained in:
Brian Smith 2023-11-04 12:05:56 -07:00
parent e51c88a986
commit d8e9a9172c
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/rsa/keypair.rs
View File

@ -663,7 +663,7 @@ impl KeyPair {
// minimum value, since the relationship of `e` to `d`, `p`, and `q` is
// not verified during `KeyPair` construction.
{
let verify = self.public.inner().exponentiate_elem(m.clone());
let verify = self.public.inner().exponentiate_elem(&m);
bigint::elem_verify_equal_consttime(&verify, &c)?;
}

6
src/rsa/public_key.rs
View File

@ -162,7 +162,7 @@ impl Inner {
}
// Step 2.
let m = self.exponentiate_elem(s);
let m = self.exponentiate_elem(&s);
// Step 3.
Ok(fill_be_bytes_n(m, self.n.len_bits(), out_buffer))
@ -171,7 +171,7 @@ impl Inner {
/// Calculates base**e (mod n).
///
/// This is constant-time with respect to `base` only.
pub(super) fn exponentiate_elem(&self, base: bigint::Elem<N>) -> bigint::Elem<N> {
pub(super) fn exponentiate_elem(&self, base: &bigint::Elem<N>) -> bigint::Elem<N> {
// The exponent was already checked to be at least 3.
let exponent_without_low_bit = NonZeroU64::try_from(self.e.value().get() & !1).unwrap();
// The exponent was already checked to be odd.
@ -189,7 +189,7 @@ impl Inner {
let acc = bigint::elem_exp_vartime(base_r, exponent_without_low_bit, n);
// Now do the multiplication for the low bit and convert out of the Montgomery domain.
bigint::elem_mul(&base, acc, n)
bigint::elem_mul(base, acc, n)
}
}