yggdrasil/ring
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
ring/crypto
History
David Benjamin 0c069cbf33 Don't consume the newline in BIO_gets for fds 
We support BIO_gets on three BIOs. They're all slightly different. File
BIOs have the NUL truncation bug. fd BIOs swallow the embedded newline.
This CL fixes the second issue and updates the BIO_gets test to cover
all three.

See also upstream's https://github.com/openssl/openssl/pull/3442

Update-Note: BIO_gets on an fd BIO now returns the newline, to align
with memory and file BIOs. BIO_gets is primarily used in the PEM parser,
which tries to tolerate both cases, but this reduces the risk of some
weird bug that only appears in fd BIOs.

Change-Id: Ia8ffb8c67b6981d6ef7144a1522f8605dc01d525
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/58552
Reviewed-by: Bob Beck <bbe@google.com>
Commit-Queue: David Benjamin <davidben@google.com>
2023-04-10 13:37:53 +00:00
..
asn1
Give X509 an ASN1_ITEM again
2023-03-22 18:37:42 +00:00
base64
Replace OPENSSL_STATIC_ASSERT with static_assert.
2022-07-30 20:16:43 +00:00
bio
Don't consume the newline in BIO_gets for fds
2023-04-10 13:37:53 +00:00
blake2
Workaround yet more NULL + 0 language bugs
2023-02-27 21:49:02 +00:00
bn_extra
Make OPENSSL_malloc push ERR_R_MALLOC_FAILURE on failure.
2023-02-13 22:13:11 +00:00
buf
Make OPENSSL_malloc push ERR_R_MALLOC_FAILURE on failure.
2023-02-13 22:13:11 +00:00
bytestring
Rewrite c2i_ASN1_OBJECT
2023-03-16 23:46:11 +00:00
chacha
Move data from .text to .rodata on x86_64
2023-02-23 19:47:14 +00:00
cipher_extra
Move data from .text to .rodata on x86_64
2023-02-23 19:47:14 +00:00
conf
Make OPENSSL_malloc push ERR_R_MALLOC_FAILURE on failure.
2023-02-13 22:13:11 +00:00
curve25519
Stop clang from un-constant-timing copy_from_prebuf.
2023-02-03 17:07:57 +00:00
des
Remove unnecessary L suffixes on DES constants.
2022-12-03 00:10:21 +00:00
dh_extra
Finish porting dh_test.cc and ripemd_test.cc to GTest.
2022-12-09 02:23:13 +00:00
digest_extra
Make OPENSSL_malloc push ERR_R_MALLOC_FAILURE on failure.
2023-02-13 22:13:11 +00:00
dsa
Cap the number of ECDSA and DSA sign iterations.
2023-02-23 15:59:47 +00:00
ec_extra
Implement P256_XMD:SHA-256_SSWU_RO_ and P384_XMD:SHA-384_SSWU_RO_
2023-02-14 15:56:40 +00:00
ecdh_extra
Fix various malloc failure paths.
2023-02-06 21:33:21 +00:00
ecdsa_extra
Some CBB_init_fixed simplifications.
2022-10-11 21:24:34 +00:00
engine
Give ENGINE_free a return value.
2019-04-17 20:57:57 +00:00
err
Cap the number of ECDSA and DSA sign iterations.
2023-02-23 15:59:47 +00:00
evp
Remove EVP_PKEY_ASN1_METHOD and EVP_PKEY_METHOD from public headers
2023-03-07 20:32:17 +00:00
fipsmodule
Add CTRDBG_STATE to bssl::UniquePtr
2023-03-15 22:55:24 +00:00
hkdf
Add EVP_PKEY_HKDF for OpenSSL compatibility.
2022-06-08 16:33:00 +00:00
hmac_extra
Miscellaneous -Wshorten-64-to-32 fixes.
2022-10-25 20:21:33 +00:00
hpke
Make OPENSSL_malloc push ERR_R_MALLOC_FAILURE on failure.
2023-02-13 22:13:11 +00:00
hrss
Revert "Drop HRSS assembly."
2023-02-08 21:48:53 +00:00
kyber
Adding a C implementation of Kyber.
2023-03-30 17:05:20 +00:00
lhash
Fix build with MSVC 2022.
2022-06-14 17:57:23 +00:00
obj
Define a NID for P-384 + Kyber768.
2023-02-28 23:12:58 +00:00
pem
Make OPENSSL_malloc push ERR_R_MALLOC_FAILURE on failure.
2023-02-13 22:13:11 +00:00
perlasm
Work around a NASM bug
2023-03-06 20:05:26 +00:00
pkcs7
Make OPENSSL_malloc push ERR_R_MALLOC_FAILURE on failure.
2023-02-13 22:13:11 +00:00
pkcs8
Make OPENSSL_malloc push ERR_R_MALLOC_FAILURE on failure.
2023-02-13 22:13:11 +00:00
poly1305
Fully condition all assembly files.
2022-12-08 21:30:05 +00:00
pool
Switch CRYPTO_BUFFER_POOL to SipHash-2-4.
2022-01-24 19:05:20 +00:00
rand_extra
Revert "Revert "Fetch entropy from a system daemon in FIPS mode on Android.""
2023-02-22 23:16:30 +00:00
rc4
Flatten most of the crypto target.
2018-09-05 23:41:25 +00:00
rsa_extra
Fix various malloc failure paths.
2023-02-06 21:33:21 +00:00
siphash
Replace some more C unions.
2022-06-08 18:05:50 +00:00
stack
Const-correct sk_FOO_cmp_func
2023-03-29 00:29:21 +00:00
test
Make boringssl_gtest_main a STATIC library
2023-02-15 19:50:04 +00:00
trust_token
RESOURCE_LEAK in method STACK_OF(TRUST_TOKEN) *voprf_unblind before return 0
2023-04-10 12:16:23 +00:00
x509
Fix handling of critical X.509 policy constraints
2023-03-30 04:56:45 +00:00
x509v3
Const-correct sk_FOO_cmp_func
2023-03-29 00:29:21 +00:00
abi_self_test.cc
Remove ppc64le assembly.
2023-01-27 14:19:27 +00:00
CMakeLists.txt
Adding a C implementation of Kyber.
2023-03-30 17:05:20 +00:00
compiler_test.cc
Add a few more assertions to compiler_test.cc.
2023-03-03 23:02:08 +00:00
constant_time_test.cc
Add a value barrier to constant-time selects.
2019-06-19 17:19:13 +00:00
cpu_aarch64_apple.c
Use the new macOS sysctl names when available
2022-09-13 18:04:21 +00:00
cpu_aarch64_freebsd.c
Also detect Armv8.2 SHA-512 extensions on FreeBSD.
2022-10-12 17:55:46 +00:00
cpu_aarch64_fuchsia.c
Add ARMV8_SHA512 detection for Fuchsia.
2022-01-20 00:50:48 +00:00
cpu_aarch64_linux.c
Move CPU detection symbols to crypto/internal.h.
2022-01-07 18:33:50 +00:00
cpu_aarch64_win.c
Move CPU detection symbols to crypto/internal.h.
2022-01-07 18:33:50 +00:00
cpu_arm_freebsd.c
Add support for arm/aarch64 on FreeBSD
2022-10-12 15:11:58 +00:00
cpu_arm_linux_test.cc
Require getauxval on 32-bit Arm Linux
2023-02-23 23:58:38 +00:00
cpu_arm_linux.c
Require getauxval on 32-bit Arm Linux
2023-02-23 23:58:38 +00:00
cpu_arm_linux.h
Require getauxval on 32-bit Arm Linux
2023-02-23 23:58:38 +00:00
cpu_arm.c
Move CPU detection symbols to crypto/internal.h.
2022-01-07 18:33:50 +00:00
cpu_intel.c
Move CPU detection symbols to crypto/internal.h.
2022-01-07 18:33:50 +00:00
crypto_test.cc
Allow the integrity test to be run on demand.
2022-03-21 19:32:15 +00:00
crypto.c
Remove ppc64le assembly.
2023-01-27 14:19:27 +00:00
ex_data.c
Make OPENSSL_malloc push ERR_R_MALLOC_FAILURE on failure.
2023-02-13 22:13:11 +00:00
impl_dispatch_test.cc
Check static CPU capabilities on x86.
2022-02-23 19:17:28 +00:00
internal.h
Make OPENSSL_malloc push ERR_R_MALLOC_FAILURE on failure.
2023-02-13 22:13:11 +00:00
mem.c
Make OPENSSL_malloc push ERR_R_MALLOC_FAILURE on failure.
2023-02-13 22:13:11 +00:00
refcount_c11.c
Replace OPENSSL_STATIC_ASSERT with static_assert.
2022-07-30 20:16:43 +00:00
refcount_lock.c
Replace OPENSSL_STATIC_ASSERT with static_assert.
2022-07-30 20:16:43 +00:00
refcount_test.cc
Rename OPENSSL_NO_THREADS, part 1.
2018-09-26 19:10:02 +00:00
self_test.cc
Use a smaller hex digest in FIPS flag files when SHA-256 used.
2019-10-01 19:18:33 +00:00
thread_none.c
Rename OPENSSL_NO_THREADS, part 1.
2018-09-26 19:10:02 +00:00
thread_pthread.c
Make ERR and thread use system malloc.
2023-02-11 17:32:19 +00:00
thread_test.cc
Add CRYPTO_pre_sandbox_init.
2020-05-14 18:17:12 +00:00
thread_win.c
Make ERR and thread use system malloc.
2023-02-11 17:32:19 +00:00
thread.c
Remove a bunch of unnecessary includes.
2016-06-28 20:31:14 +00:00