yggdrasil-old/kernel
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Remove .access() vnode operation as UID:GID/mode are stored directly in

Browse Source 
the vnode itself
This commit is contained in:
Mark
2020-01-26 21:06:43 +02:00
parent 0e66f05cad
commit 071c37fce9
2 changed files with 1 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files
include/sys/fs/node.h
-1
View File
@@ -44,7 +44,6 @@ struct vnode_operations {
off_t (*lseek) (struct ofile *fd, off_t offset, int whence);
int (*stat) (struct vnode *at, struct stat *st);
int (*access) (struct vnode *node, uid_t *uid, gid_t *gid, mode_t *mode);
int (*chmod) (struct vnode *node, mode_t mode);
int (*chown) (struct vnode *node, uid_t uid, gid_t gid);
sys/vfs/vfs_access.c
+1 -17
View File
@@ -52,24 +52,8 @@ int vfs_access_check(struct vfs_ioctx *ctx, int desm, mode_t mode, uid_t uid, gi
}
int vfs_access_node(struct vfs_ioctx *ctx, struct vnode *vn, int mode) {
mode_t vn_mode;
uid_t vn_uid;
gid_t vn_gid;
int res;
_assert(ctx);
_assert(vn);
if (!vn->op || !vn->op->access) {
vn_mode = vn->mode;
vn_uid = vn->uid;
vn_gid = vn->gid;
} else {
// Filesystem has non-trivial permission storage
if ((res = vn->op->access(vn, &vn_uid, &vn_gid, &vn_mode)) != 0) {
return res;
}
}
return vfs_access_check(ctx, mode, vn_mode, vn_uid, vn_gid);
return vfs_access_check(ctx, mode, vn->mode, vn->uid, vn->gid);
}