Re: Bug 23686, two segment faults in nm

The fix for pr23686 had a hole in the reloc address sanity check,
the calculation could overflow.  Note that stabsize is known to be a
non-zero multiple of 12 so stabsize - 4 can't underflow.

	PR 23686
	* syms.c (_bfd_stab_section_find_nearest_line): Correct
	r->address sanity check.
This commit is contained in:
Alan Modra
2023-05-20 21:00:25 +09:30
parent cb3f0ff479
commit 0bbd2b1ad0
+1 -1
View File
@@ -1106,7 +1106,7 @@ _bfd_stab_section_find_nearest_line (bfd *abfd,
|| r->howto->pc_relative
|| r->howto->bitpos != 0
|| r->howto->dst_mask != 0xffffffff
|| octets + 4 > stabsize)
|| octets > stabsize - 4)
{
_bfd_error_handler
(_("unsupported .stab relocation"));