objcopy memory leaks

This fixes some objcopy memory leaks.  commit 450da4bd38 used
xatexit to tidy most of the hash table memory, but of course that's
ineffective without a call to xexit.  The other major memory leak
happens if there is an error of some sort writing the output file, due
to not closing the input file and thus not freeing memory attached to
the bfd.

	* objcopy.c (copy_file): Don't return when bfd_close of output
	gives an error, always bfd_close input too.
	(main): Call xexit.
This commit is contained in:
Alan Modra
2023-02-12 22:34:27 +10:30
parent f6b9eb5e29
commit 3eef3b2c2d
+1 -2
View File
@@ -3934,14 +3934,12 @@ copy_file (const char *input_filename, const char *output_filename, int ofd,
{
status = 1;
bfd_nonfatal_message (output_filename, NULL, NULL, NULL);
return;
}
if (!bfd_close (ibfd))
{
status = 1;
bfd_nonfatal_message (input_filename, NULL, NULL, NULL);
return;
}
}
else
@@ -6093,5 +6091,6 @@ main (int argc, char *argv[])
END_PROGRESS (program_name);
xexit (status);
return status;
}